Page MenuHomePhabricator

Apply reviewer changes from Herald via ModularTransactions
ClosedPublic

Authored by epriestley on Mar 20 2017, 3:47 PM.
Tags
None
Referenced Files
F15573197: D17511.diff
Mon, May 5, 7:53 PM
F15541403: D17511.id.diff
Fri, Apr 25, 11:42 AM
F15538869: D17511.diff
Thu, Apr 24, 10:00 PM
F15451087: D17511.id42120.diff
Mar 28 2025, 8:03 PM
F15450197: D17511.id42136.diff
Mar 28 2025, 2:29 PM
F15436240: D17511.id.diff
Mar 25 2025, 12:48 PM
F15433697: D17511.diff
Mar 25 2025, 12:18 AM
F15423524: D17511.id42136.diff
Mar 22 2025, 3:49 PM
Subscribers
None

Details

Summary

Ref T10967. This converts the reviewer update action in Herald from an older edge write to a newer ModularTransactions write.

The major value from this is that we get a double-write to the new reviewers table.

Test Plan
  • Wrote a Herald rule to add a reviewer and a blocking reviewer.
  • Saw them added properly to a revision with: no reviewers; both as blocking; A as blocking, B as nonblocking; A as nonblocking, B as blocking.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 20 2017, 4:05 PM
This revision was automatically updated to reflect the committed changes.