Page MenuHomePhabricator

Apply reviewer changes from Herald via ModularTransactions
ClosedPublic

Authored by epriestley on Mar 20 2017, 3:47 PM.
Tags
None
Referenced Files
F19148259: D17511.diff
Dec 10 2025, 5:24 PM
F19096963: D17511.diff
Dec 4 2025, 11:54 AM
F19096914: D17511.id42120.diff
Dec 4 2025, 11:26 AM
F19096913: D17511.id42136.diff
Dec 4 2025, 11:26 AM
F19096895: D17511.id.diff
Dec 4 2025, 11:18 AM
F19093899: D17511.diff
Dec 3 2025, 10:43 PM
F18900044: D17511.id.diff
Nov 7 2025, 8:28 PM
F18889131: D17511.diff
Nov 7 2025, 8:06 AM
Subscribers
None

Details

Summary

Ref T10967. This converts the reviewer update action in Herald from an older edge write to a newer ModularTransactions write.

The major value from this is that we get a double-write to the new reviewers table.

Test Plan
  • Wrote a Herald rule to add a reviewer and a blocking reviewer.
  • Saw them added properly to a revision with: no reviewers; both as blocking; A as blocking, B as nonblocking; A as nonblocking, B as blocking.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 20 2017, 4:05 PM
This revision was automatically updated to reflect the committed changes.