Differential D17476

Show only open tasks on Tasks people profile panel
ClosedPublic
Actions

Authored by chad on Mar 7 2017, 1:35 AM.

Details

Reviewers

epriestley

Commits

rP0b4ccdade9ab: Show only open tasks on Tasks people profile panel

Summary

This currently queries all tasks, make it limit to only open tasks.

Test Plan

Assign myself an open and a resolved task. See only open on profile.

Diff Detail

Repository

rP Phabricator

Branch

restrict-tasks (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15930
Build 21096: Run Core Tests
Build 21095: arc lint + arc unit

Event Timeline

chad created this revision.Mar 7 2017, 1:35 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 7 2017, 1:35 AM

Harbormaster completed remote builds in B15930: Diff 42024.Mar 7 2017, 1:36 AM

epriestley accepted this revision.Mar 7 2017, 3:32 PM

This revision is now accepted and ready to land.Mar 7 2017, 3:32 PM

epriestley added inline comments.Mar 7 2017, 3:32 PM

src/applications/people/controller/PhabricatorPeopleProfileTasksController.php
67–70	(You can omit this if you want, since it's the default behavior.)
80	This could perhaps say "No open, assigned tasks." and likewise for the header, although maybe that's obvious enough.

Closed by commit rP0b4ccdade9ab: Show only open tasks on Tasks people profile panel (authored by chad, committed by chad). · Explain WhyMar 7 2017, 3:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleProfileTasksController.php

3 lines

Diff 42024

View Options

src/applications/people/controller/PhabricatorPeopleProfileTasksController.php

Show only open tasks on Tasks people profile panelClosedPublicActions