Page MenuHomePhabricator

Add a generic "edge.search" method
ClosedPublic

Authored by epriestley on Mar 4 2017, 5:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 8, 6:49 AM
Unknown Object (File)
Wed, Aug 3, 10:07 PM
Unknown Object (File)
Wed, Aug 3, 7:52 AM
Unknown Object (File)
Sat, Jul 30, 11:28 PM
Unknown Object (File)
Mon, Jul 25, 1:28 PM
Unknown Object (File)
Mon, Jul 18, 11:55 PM
Unknown Object (File)
Thu, Jul 14, 9:06 AM
Unknown Object (File)
Tue, Jul 12, 7:47 AM
Subscribers
None

Details

Summary

Ref T12337. Ref T5873. This provides a generic "edge.search" method which feels like other "verison 3" *.search methods.

The major issues here are:

  1. Edges use constants internally, which aren't great for an API.
  2. A lot of edges are internal and probably not useful to query.
  3. Edges don't have a real "id", so paginating them properly is challenging.

I've solved these things like this:

  • Edges must opt-in to being available via Conduit by providing a human-readable key (like "mention" instead of "52"). This solvs (1) and (2).
  • I faked a mostly-reasonable behavior for paginating.
Test Plan

Ran various valid and invalid searches. Paginated a large search. Reviewed UI.

Screen Shot 2017-03-04 at 9.47.21 AM.png (1×1 px, 164 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

which feels like

Well, somewhat like. I could put the sourcePHIDs and such in a constraints parameter, but that felt more confusing than helpful even though it would make them feel a little more similar.

This revision is now accepted and ready to land.Mar 4 2017, 8:33 PM
This revision was automatically updated to reflect the committed changes.