Page MenuHomePhabricator

Lock `files.video-mime-types` config option for consistency
ClosedPublic

Authored by epriestley on Mar 3 2017, 11:43 AM.
Tags
None
Referenced Files
F14658006: D17454.diff
Sat, Jan 11, 9:28 PM
Unknown Object (File)
Dec 12 2024, 4:48 AM
Unknown Object (File)
Dec 11 2024, 9:56 AM
Unknown Object (File)
Dec 10 2024, 6:33 PM
Unknown Object (File)
Nov 30 2024, 9:20 AM
Unknown Object (File)
Nov 24 2024, 4:59 PM
Unknown Object (File)
Nov 21 2024, 12:48 PM
Unknown Object (File)
Nov 17 2024, 4:45 AM
Subscribers
None

Details

Summary

This is a consistency change to make this option consistent with audio-mime-types, image-mime-types and icon-mime-types, all of which are locked.

(They're locked because SVG is definitely dangerous, and other types might be dangerous or might become dangerous in the future, although I'm not aware of any actual dangers from video types today.)

Test Plan

Viewed files.video-mime-types in Config, saw it was locked.

Diff Detail

Repository
rP Phabricator
Branch
video1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15878
Build 21018: Run Core Tests
Build 21017: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 3 2017, 2:34 PM
This revision was automatically updated to reflect the committed changes.