Page MenuHomePhabricator
Differential D17454

Lock `files.video-mime-types` config option for consistency
ClosedPublic
Actions

Authored by epriestley on Mar 3 2017, 11:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 6:14 PM
Unknown Object (File)
Wed, Apr 24, 9:53 PM
Unknown Object (File)
Sun, Apr 21, 3:47 PM
Unknown Object (File)
Wed, Apr 17, 2:41 PM
Unknown Object (File)
Tue, Apr 16, 5:38 AM
Unknown Object (File)
Thu, Apr 11, 7:02 AM
Unknown Object (File)
Mon, Apr 8, 1:33 AM
Unknown Object (File)
Mar 29 2024, 12:55 PM
View All 88 Files
Subscribers
None

Details

Reviewers
chad
Commits
rPc102620a298f: Lock `files.video-mime-types` config option for consistency
Summary

This is a consistency change to make this option consistent with audio-mime-types, image-mime-types and icon-mime-types, all of which are locked.

(They're locked because SVG is definitely dangerous, and other types might be dangerous or might become dangerous in the future, although I'm not aware of any actual dangers from video types today.)

Test Plan

Viewed files.video-mime-types in Config, saw it was locked.

Diff Detail

Repository
rP Phabricator
Branch
video1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15878
Build 21018: Run Core Tests
Build 21017: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 3 2017, 11:43 AM
Harbormaster completed remote builds in B15878: Diff 41974.Mar 3 2017, 11:44 AM
chad accepted this revision.Mar 3 2017, 2:34 PM
This revision is now accepted and ready to land.Mar 3 2017, 2:34 PM
Closed by commit rPc102620a298f: Lock `files.video-mime-types` config option for consistency (authored by epriestley, committed by epriestley). · Explain WhyMar 3 2017, 4:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
files/
config/
1 line

Diff 41974

View Options

src/applications/files/config/PhabricatorFilesConfigOptions.php

Loading...
Phabricator · Built by Phacility