Page MenuHomePhabricator

When editing a subtyped object, use edit forms of the same subtype
ClosedPublic

Authored by epriestley on Mar 2 2017, 1:04 AM.
Tags
None
Referenced Files
F19076597: D17445.diff
Mon, Dec 1, 12:28 PM
F19076511: D17445.diff
Mon, Dec 1, 12:18 PM
F19039100: D17445.diff
Wed, Nov 26, 6:47 AM
F18871587: D17445.diff
Nov 4 2025, 11:32 PM
F18843240: D17445.id41957.diff
Oct 28 2025, 9:11 PM
F18843239: D17445.id41942.diff
Oct 28 2025, 9:11 PM
F18843238: D17445.id.diff
Oct 28 2025, 9:11 PM
F18842054: D17445.diff
Oct 28 2025, 1:08 PM
Subscribers
None

Details

Summary

Ref T12314. When we pick an "Edit" form for a subtyped object, only consider forms with the same subtype.

For example, editing an "Animal" uses the forms with subtype "animal" which are marked as edit forms.

This also makes "Create Subtask" carry the parent task's type.

Test Plan
  • Edited an Animal, got an animal edit form.
  • Edited a normal task, got a normal task form.
  • Edited a paste, got the normal workflow.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable