Fix italics issue with nux state on homepage
ClosedPublic
Actions

Authored by chad on Feb 25 2017, 9:14 PM.

Tags

None

Referenced Files

	F14407973: D17415.id41879.diff
	Tue, Dec 24, 4:01 AM

	F14407765: D17415.id.diff
	Tue, Dec 24, 3:40 AM

	Unknown Object (File)
	Fri, Dec 20, 5:27 PM

	Unknown Object (File)
	Wed, Dec 18, 12:37 PM

	Unknown Object (File)
	Wed, Dec 18, 12:37 PM

	Unknown Object (File)
	Wed, Dec 18, 12:37 PM

	Unknown Object (File)
	Wed, Dec 18, 12:37 PM

	Unknown Object (File)
	Wed, Dec 18, 5:45 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP59207fcfac37: Fix italics issue with nux state on homepage

Summary

We moved to having "no data" strings render in italics, but sometimes it doesn't make sense. This renders out the panel a little more expected.

Test Plan

Clean install of Phabricator, read home page activity box.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Feb 25 2017, 9:14 PM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 25 2017, 9:14 PM

Harbormaster completed remote builds in B15779: Diff 41878.Feb 25 2017, 9:15 PM

epriestley accepted this revision.Feb 25 2017, 11:23 PM

This revision is now accepted and ready to land.Feb 25 2017, 11:23 PM

Closed by commit rP59207fcfac37: Fix italics issue with nux state on homepage (authored by chad, committed by chad). · Explain WhyFeb 25 2017, 11:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

home/

view/

PHUIHomeView.php

16 lines

Diff 41879

View Options

src/applications/home/view/PHUIHomeView.php

Fix italics issue with nux state on homepageClosedPublicActions