Paths

Table of Contentst

When the profiler is active, keep it active if the user submits forms
ClosedPublic
Actions

Authored by epriestley on Feb 23 2017, 5:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 26, 10:45 AM

	Unknown Object (File)
	Thu, Nov 21, 4:52 PM

	Unknown Object (File)
	Sun, Nov 17, 11:11 PM

	Unknown Object (File)
	Wed, Nov 13, 6:26 PM

	Unknown Object (File)
	Sun, Nov 10, 4:51 AM

	Unknown Object (File)
	Fri, Nov 8, 2:32 PM

	Unknown Object (File)
	Fri, Nov 8, 1:12 PM

	Unknown Object (File)
	Fri, Nov 8, 5:38 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile

Commits

rPad032e72caff: When the profiler is active, keep it active if the user submits forms

Summary

Ref T12297. When a page is generated with the profiler active, keep it active by adding a __profile__ input to any forms we generate.

Test Plan

Hit Conduit API page with __profile__ active, saw it reflected in forms.

Diff Detail

Repository

rP Phabricator

Branch

profile1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15735
Build 20792: Run Core Tests
Build 20791: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 23 2017, 5:31 PM

Harbormaster completed remote builds in B15735: Diff 41838.Feb 23 2017, 5:33 PM

chad accepted this revision.Feb 23 2017, 5:36 PM

This revision is now accepted and ready to land.Feb 23 2017, 5:36 PM

Closed by commit rPad032e72caff: When the profiler is active, keep it active if the user submits forms (authored by epriestley, committed by epriestley). · Explain WhyFeb 23 2017, 7:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

javelin/

markup.php

13 lines

Diff 41838

View Options

src/infrastructure/javelin/markup.php

When the profiler is active, keep it active if the user submits formsClosedPublicActions