Paths

Table of Contentst

Differential D17395

Hide Conpherence durable column when printing
ClosedPublic
Actions

Authored by chad on Feb 22 2017, 5:44 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T12303: Print View in Phriction shows Persistent Chat

Commits

rP254ee82a0c9d: Hide Conpherence durable column when printing

Summary

Fixes T12303. Hides column.

Test Plan

Print a page with __print__=1

Diff Detail

Repository

rP Phabricator

Branch

printable (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15723
Build 20777: Run Core Tests
Build 20776: arc lint + arc unit

Event Timeline

chad created this revision.Feb 22 2017, 5:44 PM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 22 2017, 5:44 PM

Harbormaster completed remote builds in B15722: Diff 41825.Feb 22 2017, 5:45 PM

epriestley accepted this revision.Feb 22 2017, 8:22 PM

This revision is now accepted and ready to land.Feb 22 2017, 8:22 PM

Actually, this needs a !print block to actually work when printed, I think. Try printing to PDF?

This revision now requires changes to proceed.Feb 22 2017, 8:23 PM

This diff was intended for the Phriction action of "Print Page" which does a bunch of other formatting vs. ⌘ + P

hide it everywhere

epriestley accepted this revision.Feb 22 2017, 8:30 PM

This revision is now accepted and ready to land.Feb 22 2017, 8:30 PM

Harbormaster completed remote builds in B15723: Diff 41826.Feb 22 2017, 8:31 PM

Closed by commit rP254ee82a0c9d: Hide Conpherence durable column when printing (authored by chad, committed by chad). · Explain WhyFeb 22 2017, 8:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

application/

conpherence/

durable-column.css

4 lines

Diff 41826

View Options

resources/celerity/map.php