Page MenuHomePhabricator
Differential D17395

Hide Conpherence durable column when printing
ClosedPublic
Actions

Authored by chad on Feb 22 2017, 5:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 5:05 AM
Unknown Object (File)
Fri, Nov 22, 8:13 PM
Unknown Object (File)
Tue, Nov 19, 6:35 AM
Unknown Object (File)
Fri, Nov 15, 1:39 PM
Unknown Object (File)
Mon, Nov 11, 11:09 AM
Unknown Object (File)
Sun, Nov 10, 11:03 AM
Unknown Object (File)
Wed, Nov 6, 11:53 PM
Unknown Object (File)
Fri, Nov 1, 3:15 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T12303: Print View in Phriction shows Persistent Chat
Commits
rP254ee82a0c9d: Hide Conpherence durable column when printing
Summary

Fixes T12303. Hides column.

Test Plan

Print a page with __print__=1

Diff Detail

Repository
rP Phabricator
Branch
printable (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15723
Build 20777: Run Core Tests
Build 20776: arc lint + arc unit

Event Timeline

chad created this revision.Feb 22 2017, 5:44 PM
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 22 2017, 5:44 PM
Harbormaster completed remote builds in B15722: Diff 41825.Feb 22 2017, 5:45 PM
epriestley accepted this revision.Feb 22 2017, 8:22 PM
This revision is now accepted and ready to land.Feb 22 2017, 8:22 PM
epriestley requested changes to this revision.Feb 22 2017, 8:23 PM

Actually, this needs a !print block to actually work when printed, I think. Try printing to PDF?

This revision now requires changes to proceed.Feb 22 2017, 8:23 PM
chad added a comment.Feb 22 2017, 8:25 PM

pasted_file (2×2 px, 240 KB)

chad added a comment.Feb 22 2017, 8:29 PM

This diff was intended for the Phriction action of "Print Page" which does a bunch of other formatting vs. ⌘ + P

chad updated this revision to Diff 41826.Feb 22 2017, 8:29 PM
chad edited edge metadata.
  • hide it everywhere
epriestley accepted this revision.Feb 22 2017, 8:30 PM
This revision is now accepted and ready to land.Feb 22 2017, 8:30 PM
Harbormaster completed remote builds in B15723: Diff 41826.Feb 22 2017, 8:31 PM
Closed by commit rP254ee82a0c9d: Hide Conpherence durable column when printing (authored by chad, committed by chad). · Explain WhyFeb 22 2017, 8:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
application/
conpherence/
4 lines

Diff 41826

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/durable-column.css

Loading...
Phabricator · Built by Phacility