Page MenuHomePhabricator
Differential D17391

Update people hovercard UI
ClosedPublic
Actions

Authored by chad on Feb 21 2017, 9:48 PM.
Tags
None
Referenced Files
F13176285: D17391.diff
Wed, May 8, 12:24 PM
Unknown Object (File)
Wed, Apr 10, 12:04 AM
Unknown Object (File)
Apr 7 2024, 4:57 PM
Unknown Object (File)
Apr 1 2024, 9:53 PM
Unknown Object (File)
Mar 31 2024, 12:38 PM
Unknown Object (File)
Mar 20 2024, 11:33 PM
Unknown Object (File)
Mar 19 2024, 5:56 PM
Unknown Object (File)
Mar 19 2024, 5:56 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP89ce42c15c03: Update people hovercard UI
Summary

Removes Badges, they felt awkward. Updates UI, larger image, better layout, more icons.

Test Plan

Review numerous layouts with fancy new search tool.

Diff Detail

Repository
rP Phabricator
Branch
hovercard-people (branched from master)
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/people/view/PhabricatorUserCardView.php:90XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 15712
Build 20757: Run Core Tests
Build 20756: arc lint + arc unit

Event Timeline

chad created this revision.Feb 21 2017, 9:48 PM
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 21 2017, 9:48 PM
Harbormaster completed remote builds in B15712: Diff 41815.Feb 21 2017, 9:49 PM
chad updated this revision to Diff 41816.Feb 21 2017, 10:10 PM
  • grey out user image on hovercards and profile
Harbormaster completed remote builds in B15713: Diff 41816.Feb 21 2017, 10:11 PM
chad updated this revision to Diff 41817.Feb 21 2017, 10:18 PM
  • truncate long names
epriestley accepted this revision.Feb 21 2017, 10:19 PM

Disabled? More like WASTED

wasted.gif (216×304 px, 1 MB)

This revision is now accepted and ready to land.Feb 21 2017, 10:19 PM
Harbormaster completed remote builds in B15714: Diff 41817.Feb 21 2017, 10:19 PM
chad added inline comments.Feb 21 2017, 10:28 PM
webroot/rsrc/css/phui/phui-icon.css
42–47

there is a generic class here, but it's not implemented everywhere

Closed by commit rP89ce42c15c03: Update people hovercard UI (authored by chad, committed by chad). · Explain WhyFeb 21 2017, 10:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
src/
applications/
people/
engineextension/
1 line
view/
98 lines
webroot/
rsrc/
css/
application/
project/
48 lines
phui/
5 lines
6 lines
2 lines

Diff 41815

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/people/engineextension/PeopleHovercardEngineExtension.php

Loading...
View Options

src/applications/people/view/PhabricatorUserCardView.php

Loading...
View Options

webroot/rsrc/css/application/project/project-card-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-badge.css

Loading...
View Options

webroot/rsrc/css/phui/phui-hovercard.css

Loading...
View Options

webroot/rsrc/css/phui/phui-icon.css

Loading...
Phabricator · Built by Phacility