Ref T2794. The logic is intended to read "loop until we're done processing messages", but is currently missing a break;. This doesn't affect behavior yet, just makes us eat way too much CPU.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T2794: Implement Phage (like Hypershell)
- Commits
- rPHUef580c9ccc21: In Phage, don't sit in a loop once we've read all messages from an agent
Saw time phage remote --hosts db001-16 status drop from 99% CPU time to <10%.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- phage3
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 15704 Build 20745: Run Core Tests Build 20744: arc lint + arc unit