Paths

Table of Contentst

In Phage, don't sit in a loop once we've read all messages from an agent
ClosedPublic
Actions

Authored by epriestley on Feb 19 2017, 3:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 17, 3:02 PM

	Unknown Object (File)
	Thu, Apr 11, 7:12 AM

	Unknown Object (File)
	Wed, Apr 10, 6:05 AM

	Unknown Object (File)
	Wed, Apr 10, 1:52 AM

	Unknown Object (File)
	Wed, Apr 10, 1:28 AM

	Unknown Object (File)
	Wed, Apr 10, 1:15 AM

	Unknown Object (File)
	Tue, Apr 9, 7:06 PM

	Unknown Object (File)
	Tue, Apr 9, 5:02 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T2794: Implement Phage (like Hypershell)

Commits

rPHUef580c9ccc21: In Phage, don't sit in a loop once we've read all messages from an agent

Summary

Ref T2794. The logic is intended to read "loop until we're done processing messages", but is currently missing a break;. This doesn't affect behavior yet, just makes us eat way too much CPU.

Test Plan

Saw time phage remote --hosts db001-16 status drop from 99% CPU time to <10%.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 19 2017, 3:04 PM

Harbormaster completed remote builds in B15704: Diff 41807.Feb 19 2017, 3:04 PM

chad accepted this revision.Feb 19 2017, 5:34 PM

This revision is now accepted and ready to land.Feb 19 2017, 5:34 PM

Closed by commit rPHUef580c9ccc21: In Phage, don't sit in a loop once we've read all messages from an agent (authored by epriestley, committed by epriestley). · Explain WhyFeb 19 2017, 6:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

phage/

action/

PhageAgentAction.php

4 lines

Diff 41810

View Options

src/phage/action/PhageAgentAction.php

In Phage, don't sit in a loop once we've read all messages from an agentClosedPublicActions