Page MenuHomePhabricator

In Phage, don't sit in a loop once we've read all messages from an agent
ClosedPublic

Authored by epriestley on Feb 19 2017, 3:04 PM.

Details

Summary

Ref T2794. The logic is intended to read "loop until we're done processing messages", but is currently missing a break;. This doesn't affect behavior yet, just makes us eat way too much CPU.

Test Plan

Saw time phage remote --hosts db001-16 status drop from 99% CPU time to <10%.

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.