Page MenuHomePhabricator

Fix errors found by PHPStan
ClosedPublic

Authored by vrana on Feb 16 2017, 12:17 PM.
Tags
None
Referenced Files
F12609866: D17364.id41755.diff
Tue, Mar 19, 2:40 AM
Unknown Object (File)
Sun, Mar 10, 3:58 AM
Unknown Object (File)
Feb 14 2024, 7:47 PM
Unknown Object (File)
Jan 26 2024, 2:03 AM
Unknown Object (File)
Dec 31 2023, 3:51 AM
Unknown Object (File)
Dec 27 2023, 9:52 AM
Unknown Object (File)
Dec 27 2023, 9:52 AM
Unknown Object (File)
Dec 24 2023, 7:08 PM
Subscribers

Details

Test Plan

Ran phpstan analyze --autoload-file=src/__phutil_library_init__.php -c phpstan.neon -l 1 src/ with phpstan.neon containing:

parameters:
    excludes_analyse:
        - */__tests__/*

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Are you on PHP7? I think the test failure might be PHP7 specific since we don't see it on the server-side tests (which run on PHP5).

The root issue behind that test failure is T10929.

src/cache/PhutilKeyValueCacheStack.php
70–73

I believe this has zero use cases, but probably fine to keep.

src/internationalization/PhutilNumber.php
8–11

This doesn't seem like a static analysis error?

This revision is now accepted and ready to land.Feb 16 2017, 12:22 PM

(I think you still have commit access, but let me know if you hit issues.)

Yes, I'm on PHP 7, PHPStan requires it.

src/internationalization/PhutilNumber.php
8–11

It's called like this from src/daemon/PhutilDaemonHandle.php and src/daemon/PhutilDaemon.php.

This revision was automatically updated to reflect the committed changes.