Fix errors found by PHPStan
ClosedPublic

Authored by vrana on Thu, Feb 16, 12:17 PM.

Details

Test Plan

Ran phpstan analyze --autoload-file=src/__phutil_library_init__.php -c phpstan.neon -l 1 src/ with phpstan.neon containing:

parameters:
    excludes_analyse:
        - */__tests__/*

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vrana created this revision.Thu, Feb 16, 12:17 PM
epriestley accepted this revision.Thu, Feb 16, 12:22 PM

Are you on PHP7? I think the test failure might be PHP7 specific since we don't see it on the server-side tests (which run on PHP5).

The root issue behind that test failure is T10929.

src/cache/PhutilKeyValueCacheStack.php
70–73

I believe this has zero use cases, but probably fine to keep.

src/internationalization/PhutilNumber.php
8–11

This doesn't seem like a static analysis error?

This revision is now accepted and ready to land.Thu, Feb 16, 12:22 PM

(I think you still have commit access, but let me know if you hit issues.)

Yes, I'm on PHP 7, PHPStan requires it.

src/internationalization/PhutilNumber.php
8–11

It's called like this from src/daemon/PhutilDaemonHandle.php and src/daemon/PhutilDaemon.php.

This revision was automatically updated to reflect the committed changes.