Ran phpstan analyze --autoload-file=src/__phutil_library_init__.php -c phpstan.neon -l 1 src/ with phpstan.neon containing:
parameters:
excludes_analyse:
- */__tests__/*Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPHUcfeafaf2636d: Fix errors found by PHPStan
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Are you on PHP7? I think the test failure might be PHP7 specific since we don't see it on the server-side tests (which run on PHP5).
The root issue behind that test failure is T10929.
| src/cache/PhutilKeyValueCacheStack.php | ||
|---|---|---|
| 70–73 | I believe this has zero use cases, but probably fine to keep. | |
| src/internationalization/PhutilNumber.php | ||
| 8–11 | This doesn't seem like a static analysis error? | |
Comment Actions
Yes, I'm on PHP 7, PHPStan requires it.
| src/internationalization/PhutilNumber.php | ||
|---|---|---|
| 8–11 | It's called like this from src/daemon/PhutilDaemonHandle.php and src/daemon/PhutilDaemon.php. | |