Page MenuHomePhabricator

Add more transation data to panel tab changes
ClosedPublic

Authored by chad on Feb 15 2017, 6:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 15 2024, 8:20 PM
Unknown Object (File)
Feb 11 2024, 2:01 PM
Unknown Object (File)
Jan 25 2024, 1:32 PM
Unknown Object (File)
Jan 16 2024, 10:55 AM
Unknown Object (File)
Dec 27 2023, 9:50 AM
Unknown Object (File)
Dec 21 2023, 4:24 PM
Unknown Object (File)
Dec 21 2023, 1:27 PM
Unknown Object (File)
Nov 30 2023, 6:29 PM
Subscribers

Details

Summary

Fixes T10473. Clever, didn't know we could do this, but works well. Renders out the tab names by ', '.

Test Plan

Add a tab panel, change some names, review transactions.

pasted_file (1×944 px, 109 KB)

Diff Detail

Repository
rP Phabricator
Branch
panel-name-transaction (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15642
Build 20650: Run Core Tests
Build 20649: arc lint + arc unit

Event Timeline

Probably ambiguous when tab names have quotes and commas in them, but clearly better than what we do now.

This revision is now accepted and ready to land.Feb 15 2017, 6:56 PM

I think I'd have to query panel names from the DB to make this more better, unsure if I can do that in transactions?

It's correct to use the values on the transaction because the tabs may have changed name again after the transaction happened. If you rename "A" to "B", the old transactions should still say "Added panel A; Renamed A to B." (except that the rename is on some other object, I guess).

When this swaps to ModularTransactions there's some new rendering stuff that applies the italic style like in Differential, but not worth trying to tweak until then.

This revision was automatically updated to reflect the committed changes.