Build Badges View page into more of a profile
ClosedPublic

Authored by chad on Feb 15 2017, 5:54 PM.

Details

Summary

Ref T10798. Cleans up the UI a little and adds a sidenav.

Test Plan

Review badge and recipients in sandbox.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chad created this revision.Feb 15 2017, 5:54 PM
chad updated this revision to Diff 41743.Feb 15 2017, 6:03 PM
chad edited the summary of this revision. (Show Details)
  • fix create transaction
chad updated this revision to Diff 41744.Feb 15 2017, 6:08 PM
  • remove needRecipients
epriestley accepted this revision.Feb 15 2017, 6:55 PM
  • "BADGE" label in the menu maybe slightly weird/inconsistent? e..g, projects don't say "PROJECT".
  • "Add Recipients" uses language more like "Award Badge" elsewhere, maybe worth adjusting?
  • After adding recipients, take viewer to recipients page?
  • Put "Add recipients" action on recipients page?
This revision is now accepted and ready to land.Feb 15 2017, 6:55 PM
chad added a comment.Feb 15 2017, 6:58 PM

"BADGE" label in the menu maybe slightly weird/inconsistent? e..g, projects don't say "PROJECT".

we do this for Dashboards, and on Profiles we have a photo. Ideally, I'd always have some identifier before the menu, but it might take a few passes to find something consistent.

This revision was automatically updated to reflect the committed changes.