Page MenuHomePhabricator

Build Badges View page into more of a profile
ClosedPublic

Authored by chad on Feb 15 2017, 5:54 PM.
Tags
None
Attached Files
Unknown Object (File)
Apr 16 2017, 1:15 PM
Unknown Object (File)
Apr 16 2017, 11:31 AM
Unknown Object (File)
Apr 15 2017, 6:10 AM
Unknown Object (File)
Mar 9 2017, 5:52 AM
Unknown Object (File)
Mar 9 2017, 3:06 AM
Unknown Object (File)
Mar 6 2017, 8:29 AM
Unknown Object (File)
Mar 6 2017, 8:23 AM
Unknown Object (File)
Feb 18 2017, 5:29 AM
Subscribers

Details

Summary

Ref T10798. Cleans up the UI a little and adds a sidenav.

Test Plan

Review badge and recipients in sandbox.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad edited the summary of this revision. (Show Details)
  • fix create transaction
  • "BADGE" label in the menu maybe slightly weird/inconsistent? e..g, projects don't say "PROJECT".
  • "Add Recipients" uses language more like "Award Badge" elsewhere, maybe worth adjusting?
  • After adding recipients, take viewer to recipients page?
  • Put "Add recipients" action on recipients page?
This revision is now accepted and ready to land.Feb 15 2017, 6:55 PM

"BADGE" label in the menu maybe slightly weird/inconsistent? e..g, projects don't say "PROJECT".

we do this for Dashboards, and on Profiles we have a photo. Ideally, I'd always have some identifier before the menu, but it might take a few passes to find something consistent.

This revision was automatically updated to reflect the committed changes.