Ref T10798. Cleans up the UI a little and adds a sidenav.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T10798: Limit, order recipients list in BadgeView
- Commits
- rP9716e83d605f: Build Badges View page into more of a profile
Review badge and recipients in sandbox.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- badge-page (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 15640 Build 20646: Run Core Tests Build 20645: arc lint + arc unit
Event Timeline
Comment Actions
- "BADGE" label in the menu maybe slightly weird/inconsistent? e..g, projects don't say "PROJECT".
- "Add Recipients" uses language more like "Award Badge" elsewhere, maybe worth adjusting?
- After adding recipients, take viewer to recipients page?
- Put "Add recipients" action on recipients page?
Comment Actions
"BADGE" label in the menu maybe slightly weird/inconsistent? e..g, projects don't say "PROJECT".
we do this for Dashboards, and on Profiles we have a photo. Ideally, I'd always have some identifier before the menu, but it might take a few passes to find something consistent.