Differential D17358

Build Badges View page into more of a profile
ClosedPublic
Actions

Authored by chad on Feb 15 2017, 5:54 PM.

Tags

None

Referenced Files

	F13079195: D17358.id41749.diff
	Tue, Apr 23, 9:15 PM

	F13079194: D17358.id41744.diff
	Tue, Apr 23, 9:15 PM

	F13079193: D17358.id41743.diff
	Tue, Apr 23, 9:15 PM

	F13079192: D17358.id41742.diff
	Tue, Apr 23, 9:14 PM

	F13079191: D17358.id.diff
	Tue, Apr 23, 9:14 PM

	F13079190: D17358.diff
	Tue, Apr 23, 9:14 PM

	Unknown Object (File)
	Fri, Apr 19, 2:51 PM

	Unknown Object (File)
	Wed, Apr 17, 12:40 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T10798: Limit, order recipients list in BadgeView

Commits

rP9716e83d605f: Build Badges View page into more of a profile

Summary

Ref T10798. Cleans up the UI a little and adds a sidenav.

Test Plan

Review badge and recipients in sandbox.

Diff Detail

Repository

Branch

badge-page (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15640
Build 20646: Run Core Tests
Build 20645: arc lint + arc unit

Event Timeline

chad created this revision.Feb 15 2017, 5:54 PM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 15 2017, 5:54 PM

Harbormaster completed remote builds in B15638: Diff 41742.Feb 15 2017, 5:56 PM

chad edited the summary of this revision. (Show Details)Feb 15 2017, 6:03 PM

chad added a task: T12269: New badge transaction says "created this object"..

fix create transaction

Harbormaster completed remote builds in B15639: Diff 41743.Feb 15 2017, 6:03 PM

Harbormaster completed remote builds in B15639: Diff 41743.

remove needRecipients

Harbormaster completed remote builds in B15640: Diff 41744.Feb 15 2017, 6:09 PM

"BADGE" label in the menu maybe slightly weird/inconsistent? e..g, projects don't say "PROJECT".
"Add Recipients" uses language more like "Award Badge" elsewhere, maybe worth adjusting?
After adding recipients, take viewer to recipients page?
Put "Add recipients" action on recipients page?

This revision is now accepted and ready to land.Feb 15 2017, 6:55 PM

"BADGE" label in the menu maybe slightly weird/inconsistent? e..g, projects don't say "PROJECT".

we do this for Dashboards, and on Profiles we have a photo. Ideally, I'd always have some identifier before the menu, but it might take a few passes to find something consistent.

Closed by commit rP9716e83d605f: Build Badges View page into more of a profile (authored by chad, committed by chad). · Explain WhyFeb 15 2017, 7:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

6 lines

applications/

badges/

application/

PhabricatorBadgesApplication.php

13 lines

controller/

PhabricatorBadgesProfileController.php

88 lines

PhabricatorBadgesRecipientsController.php

58 lines

PhabricatorBadgesViewController.php

42 lines

storage/

PhabricatorBadgesTransaction.php

4 lines

Diff 41744

src/__phutil_library_map__.php

Loading...

src/applications/badges/application/PhabricatorBadgesApplication.php

Loading...

src/applications/badges/controller/PhabricatorBadgesProfileController.php

Loading...

src/applications/badges/controller/PhabricatorBadgesRecipientsController.php

Loading...

src/applications/badges/controller/PhabricatorBadgesViewController.php

Loading...

src/applications/badges/storage/PhabricatorBadgesTransaction.php

Loading...