Page MenuHomePhabricator

Fix an issue where resolveKill() emits a warning if the future was never started
ClosedPublic

Authored by epriestley on Feb 14 2017, 3:17 PM.
Tags
None
Referenced Files
F14077752: D17354.diff
Fri, Nov 22, 1:07 AM
Unknown Object (File)
Sun, Nov 17, 9:46 PM
Unknown Object (File)
Sun, Nov 10, 5:35 PM
Unknown Object (File)
Sat, Nov 9, 7:43 PM
Unknown Object (File)
Tue, Nov 5, 11:53 PM
Unknown Object (File)
Oct 21 2024, 10:03 AM
Unknown Object (File)
Oct 18 2024, 9:10 AM
Unknown Object (File)
Oct 13 2024, 3:56 PM
Subscribers
None

Details

Summary

Ref T2794. This is a minor warning I hit while exploring Phage stuff. In Phage, we can resolveKill() a future that we never called start() on, which tries to proc_terminate() a process which never spawned. This emits a warning.

Instead, check that $this->proc exists before signaling it.

Test Plan

Added a unit test.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable