Page MenuHomePhabricator

Fix an issue where resolveKill() emits a warning if the future was never started
ClosedPublic

Authored by epriestley on Feb 14 2017, 3:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 10, 4:41 AM
Unknown Object (File)
Jul 2 2026, 1:01 AM
Unknown Object (File)
Jun 22 2026, 6:50 PM
Unknown Object (File)
Jun 22 2026, 6:50 PM
Unknown Object (File)
Jun 22 2026, 6:50 PM
Unknown Object (File)
Jun 21 2026, 2:54 PM
Unknown Object (File)
Jun 21 2026, 8:14 AM
Unknown Object (File)
Jun 11 2026, 8:04 PM
Subscribers
None

Details

Summary

Ref T2794. This is a minor warning I hit while exploring Phage stuff. In Phage, we can resolveKill() a future that we never called start() on, which tries to proc_terminate() a process which never spawned. This emits a warning.

Instead, check that $this->proc exists before signaling it.

Test Plan

Added a unit test.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable