Page MenuHomePhabricator

Don't allow duplicate panels on dashboards
ClosedPublic

Authored by chad on Feb 14 2017, 4:34 AM.
Tags
None
Referenced Files
F14073816: D17351.diff
Thu, Nov 21, 2:35 AM
Unknown Object (File)
Sun, Nov 17, 3:44 PM
Unknown Object (File)
Fri, Nov 8, 6:34 PM
Unknown Object (File)
Fri, Nov 8, 10:31 AM
Unknown Object (File)
Fri, Nov 8, 8:24 AM
Unknown Object (File)
Fri, Nov 8, 8:16 AM
Unknown Object (File)
Fri, Nov 8, 8:16 AM
Unknown Object (File)
Fri, Nov 8, 7:45 AM
Subscribers

Details

Summary

Fixes T10145. I went with "don't add two panels", since panels are easy to create, I expect this to be a reasonable limit until we have better use cases.

Test Plan

Try to add the same panel twice, get error. Add panel normally fine, move panels fine, edit panels fine.

Diff Detail

Repository
rP Phabricator
Branch
dupe-panels (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15625
Build 20622: Run Core Tests
Build 20621: arc lint + arc unit

Event Timeline

Cool. I think this is a good approach, at least for the foreseeable future: the use cases right now definitely feel pretty weak to me too.

This revision is now accepted and ready to land.Feb 14 2017, 12:02 PM
This revision was automatically updated to reflect the committed changes.