Page MenuHomePhabricator
Differential D17347

Allow lightbox comments to be viewed logged out
ClosedPublic
Actions

Authored by chad on Feb 13 2017, 9:49 PM.
Tags
None
Referenced Files
F15620027: D17347.diff
Sat, May 17, 7:55 AM
Unknown Object (File)
Tue, Apr 22, 2:11 PM
Unknown Object (File)
Tue, Apr 22, 12:19 PM
Unknown Object (File)
Sat, Apr 19, 6:42 AM
Unknown Object (File)
Fri, Apr 18, 9:57 PM
Unknown Object (File)
Apr 4 2025, 6:13 AM
Unknown Object (File)
Mar 3 2025, 1:46 PM
Unknown Object (File)
Feb 25 2025, 3:08 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T12160: Lightbox asks user to log in if logged out
Commits
rPf9163bf06539: Allow lightbox comments to be viewed logged out
Summary

Fixes T12160. Lightbox thread view should be visible if file is public.

Test Plan

Add a file to a task, log out, click on file in task, get lightbox and no error. Expand comments, see login box.

Screen Shot 2017-02-13 at 1.46.14 PM.png (2×2 px, 593 KB)

pasted_file (2×2 px, 468 KB)

pasted_file (2×2 px, 393 KB)

pasted_file (2×2 px, 362 KB)

pasted_file (2×2 px, 350 KB)

Diff Detail

Repository
rP Phabricator
Branch
file-thread-perm (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15617
Build 20610: Run Core Tests
Build 20609: arc lint + arc unit

Event Timeline

chad created this revision.Feb 13 2017, 9:49 PM
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 13 2017, 9:49 PM
chad edited the test plan for this revision. (Show Details)Feb 13 2017, 9:49 PM
chad edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B15617: Diff 41719.Feb 13 2017, 9:50 PM
chad edited the test plan for this revision. (Show Details)Feb 13 2017, 9:50 PM
chad edited the test plan for this revision. (Show Details)
chad edited the test plan for this revision. (Show Details)
epriestley edited edge metadata.Feb 13 2017, 9:52 PM

um

epriestley accepted this revision.Feb 13 2017, 9:53 PM
This revision is now accepted and ready to land.Feb 13 2017, 9:53 PM
Closed by commit rPf9163bf06539: Allow lightbox comments to be viewed logged out (authored by chad, committed by chad). · Explain WhyFeb 13 2017, 9:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
files/
controller/
4 lines

Diff 41719

View Options

src/applications/files/controller/PhabricatorFileLightboxController.php

Loading...
Phabricator · Built by Phacility