Page MenuHomePhabricator

Allow lightbox comments to be viewed logged out
ClosedPublic

Authored by chad on Feb 13 2017, 9:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 8:24 AM
Unknown Object (File)
Wed, Apr 10, 10:33 PM
Unknown Object (File)
Thu, Apr 4, 6:26 AM
Unknown Object (File)
Fri, Mar 22, 10:23 PM
Unknown Object (File)
Mon, Mar 18, 8:17 PM
Unknown Object (File)
Mon, Mar 18, 7:59 AM
Unknown Object (File)
Mar 5 2024, 4:15 PM
Unknown Object (File)
Feb 19 2024, 2:16 PM
Subscribers

Details

Summary

Fixes T12160. Lightbox thread view should be visible if file is public.

Test Plan

Add a file to a task, log out, click on file in task, get lightbox and no error. Expand comments, see login box.

Screen Shot 2017-02-13 at 1.46.14 PM.png (2×2 px, 593 KB)

pasted_file (2×2 px, 468 KB)

pasted_file (2×2 px, 393 KB)

pasted_file (2×2 px, 362 KB)

pasted_file (2×2 px, 350 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad edited the test plan for this revision. (Show Details)
chad edited the test plan for this revision. (Show Details)
chad edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Feb 13 2017, 9:53 PM
This revision was automatically updated to reflect the committed changes.