Page MenuHomePhabricator

Fix a fatal when viewing methods which no longer exist in the Conduit call log
ClosedPublic

Authored by epriestley on Feb 13 2017, 2:18 PM.
Tags
None
Referenced Files
F17629400: D17342.id.diff
Thu, Jul 10, 8:48 AM
Unknown Object (File)
Jun 17 2025, 8:07 PM
Unknown Object (File)
Jun 16 2025, 9:59 PM
Unknown Object (File)
May 9 2025, 9:02 PM
Unknown Object (File)
May 8 2025, 9:36 PM
Unknown Object (File)
Apr 18 2025, 11:22 AM
Unknown Object (File)
Apr 17 2025, 5:29 AM
Unknown Object (File)
Apr 7 2025, 9:12 AM
Subscribers
None

Details

Summary

Fixes T12252.

Test Plan

I just faked this, but likely repro is:

  • Call method x.y.
  • Remove method x.y from the codebase.
  • View log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php
132–137

This ($method_status) is the variable the code is supposed to be using.

This revision is now accepted and ready to land.Feb 13 2017, 2:24 PM
This revision was automatically updated to reflect the committed changes.