Differential D17342

Fix a fatal when viewing methods which no longer exist in the Conduit call log
ClosedPublic
Actions

Authored by epriestley on Feb 13 2017, 2:18 PM.

Details

Reviewers
• chad
Maniphest Tasks
T12252: Unhandled Exception ("RuntimeException") at Conduit Call Logs page
Commits
rPb71e08966934: Fix a fatal when viewing methods which no longer exist in the Conduit call log
Summary

Fixes T12252.

Test Plan

I just faked this, but likely repro is:

  • Call method x.y.
  • Remove method x.y from the codebase.
  • View log.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
epriestley created this revision.Feb 13 2017, 2:18 PM
epriestley added inline comments.Feb 13 2017, 2:23 PM
src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php
132–137

This ($method_status) is the variable the code is supposed to be using.

• chad accepted this revision.Feb 13 2017, 2:24 PM
This revision is now accepted and ready to land.Feb 13 2017, 2:24 PM
Closed by commit rPb71e08966934: Fix a fatal when viewing methods which no longer exist in the Conduit call log (authored by epriestley). · Explain WhyFeb 13 2017, 2:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 41705

View Options

src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php

Loading...
Phabricator · Built by Phacility