Paths

Table of Contentst

Fix a fatal when viewing methods which no longer exist in the Conduit call log
ClosedPublic
Actions

Authored by epriestley on Feb 13 2017, 2:18 PM.

Tags

None

Referenced Files

	F19341060: D17342.id41704.diff
	Thu, Dec 25, 10:52 PM

	F19050667: D17342.id.diff
	Nov 27 2025, 8:45 PM

	F18825217: D17342.id.diff
	Oct 23 2025, 8:23 PM

	F18821315: D17342.diff
	Oct 22 2025, 9:53 PM

	F18812653: D17342.id.diff
	Oct 20 2025, 11:12 AM

	F18763500: D17342.id41704.diff
	Oct 7 2025, 12:30 AM

	F18745608: D17342.diff
	Oct 3 2025, 8:20 AM

	F18733465: D17342.id.diff
	Sep 30 2025, 10:35 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12252: Unhandled Exception ("RuntimeException") at Conduit Call Logs page

Commits

rPb71e08966934: Fix a fatal when viewing methods which no longer exist in the Conduit call log

Summary

Fixes T12252.

Test Plan

I just faked this, but likely repro is:

Call method x.y.
Remove method x.y from the codebase.
View log.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 13 2017, 2:18 PM

Harbormaster completed remote builds in B15603: Diff 41704.Feb 13 2017, 2:19 PM

epriestley added inline comments.Feb 13 2017, 2:23 PM

src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php
132–137	This (`$method_status`) is the variable the code is supposed to be using.

chad accepted this revision.Feb 13 2017, 2:24 PM

This revision is now accepted and ready to land.Feb 13 2017, 2:24 PM

Closed by commit rPb71e08966934: Fix a fatal when viewing methods which no longer exist in the Conduit call log (authored by epriestley, committed by epriestley). · Explain WhyFeb 13 2017, 2:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

query/

PhabricatorConduitLogSearchEngine.php

2 lines

Diff 41705

View Options

src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php

Fix a fatal when viewing methods which no longer exist in the Conduit call logClosedPublicActions