Page MenuHomePhabricator

Fix a fatal when viewing methods which no longer exist in the Conduit call log
ClosedPublic

Authored by epriestley on Feb 13 2017, 2:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 13, 6:30 AM
Unknown Object (File)
Sun, Mar 10, 2:09 PM
Unknown Object (File)
Feb 15 2024, 5:02 PM
Unknown Object (File)
Jan 26 2024, 11:08 PM
Unknown Object (File)
Dec 27 2023, 9:47 AM
Unknown Object (File)
Dec 21 2023, 4:20 PM
Unknown Object (File)
Dec 3 2023, 10:55 PM
Unknown Object (File)
Nov 30 2023, 4:20 AM
Subscribers
None

Details

Summary

Fixes T12252.

Test Plan

I just faked this, but likely repro is:

  • Call method x.y.
  • Remove method x.y from the codebase.
  • View log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php
132–137

This ($method_status) is the variable the code is supposed to be using.

This revision is now accepted and ready to land.Feb 13 2017, 2:24 PM
This revision was automatically updated to reflect the committed changes.