Page MenuHomePhabricator
Differential D17342

Fix a fatal when viewing methods which no longer exist in the Conduit call log
ClosedPublic
Actions

Authored by epriestley on Feb 13 2017, 2:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 6:14 PM
Unknown Object (File)
Fri, Apr 19, 10:07 AM
Unknown Object (File)
Tue, Apr 9, 2:32 AM
Unknown Object (File)
Fri, Apr 5, 5:23 PM
Unknown Object (File)
Fri, Apr 5, 10:49 AM
Unknown Object (File)
Fri, Apr 5, 9:21 AM
Unknown Object (File)
Fri, Apr 5, 9:21 AM
Unknown Object (File)
Fri, Apr 5, 7:27 AM
View All 66 Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12252: Unhandled Exception ("RuntimeException") at Conduit Call Logs page
Commits
rPb71e08966934: Fix a fatal when viewing methods which no longer exist in the Conduit call log
Summary

Fixes T12252.

Test Plan

I just faked this, but likely repro is:

  • Call method x.y.
  • Remove method x.y from the codebase.
  • View log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 13 2017, 2:18 PM
Harbormaster completed remote builds in B15603: Diff 41704.Feb 13 2017, 2:19 PM
epriestley added inline comments.Feb 13 2017, 2:23 PM
src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php
132–137

This ($method_status) is the variable the code is supposed to be using.

chad accepted this revision.Feb 13 2017, 2:24 PM
This revision is now accepted and ready to land.Feb 13 2017, 2:24 PM
Closed by commit rPb71e08966934: Fix a fatal when viewing methods which no longer exist in the Conduit call log (authored by epriestley, committed by epriestley). · Explain WhyFeb 13 2017, 2:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conduit/
query/
2 lines

Diff 41705

View Options

src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php

Loading...
Phabricator · Built by Phacility