Don't show an auth provider as enabled if it's still being created
ClosedPublic

Authored by amckinley on Feb 11 2017, 12:57 AM.

Details

Test Plan

attempted to create a new auth provider; observed that "enabled" ui element does not render. viewed existing auth provider and observed that "enabled" ui element still renders

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
amckinley created this revision.Feb 11 2017, 12:57 AM
epriestley requested changes to this revision.Feb 11 2017, 1:04 AM

Maybe a little simpler like this? Should be the same logically, I think.

if (!$is_new) {
  if ($config->getIsEnabled()) {
    // ...
  } else {
    // ...
  }
}
This revision now requires changes to proceed.Feb 11 2017, 1:04 AM
epriestley accepted this revision.Feb 13 2017, 3:02 PM

(I'll just tweak that in the pull.)

This revision is now accepted and ready to land.Feb 13 2017, 3:02 PM
This revision was automatically updated to reflect the committed changes.