Page MenuHomePhabricator

Remove bad "Session" link in User activity logs
ClosedPublic

Authored by epriestley on Feb 6 2017, 12:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 5:32 AM
Unknown Object (File)
Mon, Apr 22, 10:40 PM
Unknown Object (File)
Thu, Apr 11, 7:22 AM
Unknown Object (File)
Mon, Apr 8, 1:32 AM
Unknown Object (File)
Wed, Apr 3, 12:09 AM
Unknown Object (File)
Mon, Apr 1, 3:32 AM
Unknown Object (File)
Mar 22 2024, 2:11 PM
Unknown Object (File)
Feb 7 2024, 2:31 PM
Subscribers
None

Details

Summary

Fixes T12215. Two issues:

  • We build this $session link out of $ip, which is (a) wrong even if $ip was the IP and (b) super wrong since $ip is a tag.
  • These links don't work even if we'd built them right: searching by the prefix of a session identifier does nothing.

At least for now, just get rid of the links rather than trying to make this behavior work.

Test Plan

On People > Activity logs:

  • Before patch: Saw bad links with bogus targets in "session" column.
  • After patch: Saw plain text in "session" column.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable