Page MenuHomePhabricator

Remove bad "Session" link in User activity logs
ClosedPublic

Authored by epriestley on Feb 6 2017, 12:30 PM.
Tags
None
Referenced Files
F15420185: D17316.id41645.diff
Fri, Mar 21, 12:02 PM
F15420105: D17316.id41648.diff
Fri, Mar 21, 11:24 AM
F15417763: D17316.id.diff
Thu, Mar 20, 6:17 PM
F15407940: D17316.id41645.diff
Tue, Mar 18, 8:20 PM
F15405134: D17316.diff
Tue, Mar 18, 10:24 AM
F15341261: D17316.id41645.diff
Sun, Mar 9, 7:23 PM
Unknown Object (File)
Sat, Mar 1, 8:30 PM
Unknown Object (File)
Feb 9 2025, 3:13 AM
Subscribers
None

Details

Summary

Fixes T12215. Two issues:

  • We build this $session link out of $ip, which is (a) wrong even if $ip was the IP and (b) super wrong since $ip is a tag.
  • These links don't work even if we'd built them right: searching by the prefix of a session identifier does nothing.

At least for now, just get rid of the links rather than trying to make this behavior work.

Test Plan

On People > Activity logs:

  • Before patch: Saw bad links with bogus targets in "session" column.
  • After patch: Saw plain text in "session" column.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable