Remove bad "Session" link in User activity logs
ClosedPublic

Authored by epriestley on Feb 6 2017, 12:30 PM.

Details

Summary

Fixes T12215. Two issues:

  • We build this $session link out of $ip, which is (a) wrong even if $ip was the IP and (b) super wrong since $ip is a tag.
  • These links don't work even if we'd built them right: searching by the prefix of a session identifier does nothing.

At least for now, just get rid of the links rather than trying to make this behavior work.

Test Plan

On People > Activity logs:

  • Before patch: Saw bad links with bogus targets in "session" column.
  • After patch: Saw plain text in "session" column.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
epriestley created this revision.Feb 6 2017, 12:30 PM
chad accepted this revision.Feb 6 2017, 3:31 PM
This revision is now accepted and ready to land.Feb 6 2017, 3:31 PM
This revision was automatically updated to reflect the committed changes.