Allow users who can edit a dashboard to remove invalid / restricted panels

Authored by epriestley on Feb 5 2017, 12:16 AM.



Ref T12207. Currently, to remove a panel from a dashboard, it must be a valid panel which you can see.

Instead, only require that the panel PHID actually be listed somewhere in the dashboard's internal list of panels.

This interacts with the "multiple instances of a panel" issue described in some more depth in T12207. In particular:

  • Currently, you can sort of add multiple copies of a panel to a dashboard, sometimes? Maybe?
  • This leads to great tragedy.

This doesn't fix up the workflow with respect to multiple copies of a panel. We still remove by panel PHID (not by column/position or internal ID) so if a dashboard has multiple copies of the same panel for some reason, I think this workflow removes one of them arbitrarily (at best) or perhaps does something worse. I'm just treating this behavior as undefined for the moment.

Test Plan
  • Removed an invalid/hidden panel from a dashboard as a user with permission to edit that dashboard.
  • Tried to remove a made-up panel with a totally bogus PHID, got 404'd.
  • Viewed a dashboard with a restricted panel.
  • Put a hidden panel inside a tab panel, viewed it as a user who could not see it and a user who could.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
epriestley created this revision.Feb 5 2017, 12:16 AM
chad accepted this revision.Feb 5 2017, 12:31 AM
This revision is now accepted and ready to land.Feb 5 2017, 12:31 AM
This revision was automatically updated to reflect the committed changes.