Paths

Table of Contentst

Differential D17312

Add more color/CSS to phui-icon-selector
ClosedPublic
Actions

Authored by chad on Feb 4 2017, 5:41 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T12205: Icons on IconChooser are white

Commits

rPeabb4072d03e: (stable) Add more color/CSS to phui-icon-selector
rP2c691ef00999: Add more color/CSS to phui-icon-selector

Summary

Fixes T12205. These got over-ridden at a global scale (correctly) and need to adjust local scopes better. Also make it more bluer.

Test Plan

Go to Edit Dashboard, and pick a new icon for a Dashboard.

Diff Detail

Repository

rP Phabricator

Branch

button-white (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15536
Build 20487: Run Core Tests
Build 20486: arc lint + arc unit

Event Timeline

chad created this revision.Feb 4 2017, 5:41 PM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 4 2017, 5:41 PM

Harbormaster completed remote builds in B15536: Diff 41636.Feb 4 2017, 5:42 PM

epriestley accepted this revision.Feb 4 2017, 5:47 PM

This revision is now accepted and ready to land.Feb 4 2017, 5:47 PM

I'll pick this to stable since I'm still doing Audit/Owners migrations in production anyway.

Closed by commit rP2c691ef00999: Add more color/CSS to phui-icon-selector (authored by chad, committed by chad). · Explain WhyFeb 4 2017, 6:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

phui/

phui-icon-set-selector.css

21 lines

Diff 41636

View Options

resources/celerity/map.php