Page MenuHomePhabricator
Differential D17302

Widen property list key value
ClosedPublic
Actions

Authored by chad on Feb 2 2017, 9:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 10:07 PM
Unknown Object (File)
Sun, Apr 21, 4:16 PM
Unknown Object (File)
Fri, Apr 19, 6:12 PM
Unknown Object (File)
Thu, Apr 11, 7:28 AM
Unknown Object (File)
Sun, Apr 7, 6:57 AM
Unknown Object (File)
Sat, Mar 30, 4:02 AM
Unknown Object (File)
Fri, Mar 29, 9:14 AM
Unknown Object (File)
Thu, Mar 28, 11:32 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T12180: Cropped text in Property List
Commits
rP468676927374: Widen property list key value
Summary

Ref T12180. Seems we widened the value side, but not the key.

Test Plan

Review application property page. Set item to stacked, see non-cutoff layout.

Diff Detail

Repository
rP Phabricator
Branch
applications-properties (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15509
Build 20448: Run Core Tests
Build 20447: arc lint + arc unit

Event Timeline

chad created this revision.Feb 2 2017, 9:28 PM
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 2 2017, 9:28 PM
Harbormaster completed remote builds in B15509: Diff 41611.Feb 2 2017, 9:29 PM
epriestley accepted this revision.Feb 3 2017, 1:25 PM
This revision is now accepted and ready to land.Feb 3 2017, 1:25 PM
Closed by commit rP468676927374: Widen property list key value (authored by chad, committed by chad). · Explain WhyFeb 3 2017, 4:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
webroot/
rsrc/
css/
phui/
2 lines
2 lines

Diff 41611

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...
Phabricator · Built by Phacility