Paths

Table of Contentst

Fix a mismatched method definition in PhabricatorHomeProfileMenuItem
ClosedPublic
Actions

Authored by epriestley on Feb 2 2017, 2:03 PM.

Tags

None

Referenced Files

	F15496174: D17297.id41604.diff
	Sun, Apr 13, 6:14 AM

	F15484552: D17297.diff
	Wed, Apr 9, 6:58 PM

	F15464994: D17297.id41603.diff
	Wed, Apr 2, 1:30 PM

	F15436285: D17297.id.diff
	Tue, Mar 25, 1:07 PM

	F15432250: D17297.diff
	Mon, Mar 24, 5:03 PM

	F15425176: D17297.id41603.diff
	Sun, Mar 23, 3:00 AM

	F15396301: D17297.id.diff
	Mar 16 2025, 1:22 PM

	F15310026: D17297.id41604.diff
	Mar 6 2025, 7:59 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12187: Editing Menu Items leads into daemon or transaction errors
T12190: In PHP7, include-time warnings from source files are ignored

Commits

rPd0258a898175: Fix a mismatched method definition in PhabricatorHomeProfileMenuItem

Summary

Fixes T12187. Ref T12190. See T12190 for discussion of why this escaped notice.

Test Plan

Commented out the error_reporting() clause around file inclusion.
Reproduced the error in PHP7.
Corrected the method signature.
Reloaded the page, no more error.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 2 2017, 2:03 PM

Harbormaster completed remote builds in B15501: Diff 41603.Feb 2 2017, 2:04 PM

OCram mentioned this in Z1336: General Chat.Feb 2 2017, 2:09 PM

chad accepted this revision.Feb 2 2017, 2:53 PM

This revision is now accepted and ready to land.Feb 2 2017, 2:53 PM

Closed by commit rPd0258a898175: Fix a mismatched method definition in PhabricatorHomeProfileMenuItem (authored by epriestley, committed by epriestley). · Explain WhyFeb 2 2017, 3:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

home/

menuitem/

PhabricatorHomeProfileMenuItem.php

3 lines

Diff 41604

View Options

src/applications/home/menuitem/PhabricatorHomeProfileMenuItem.php

Fix a mismatched method definition in PhabricatorHomeProfileMenuItemClosedPublicActions