Add a Picture Menu Item for Profiles
ClosedPublic

Authored by chad on Thu, Feb 2, 5:23 AM.

Details

Summary

Just making profiles a little nicer, adds a big picture, easier mechanism for updating photos. Also larger profile pictures... need to re-thumb?

Test Plan

View my profile, edit my picture, view a stranger, see profile. Check mobile, tablet, desktop. Check action menu on mobile.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chad created this revision.Thu, Feb 2, 5:23 AM
chad added a comment.Thu, Feb 2, 5:25 AM

v odd:

[2017-02-02 05:23:49] ERROR 2048: Declaration of PhabricatorHomeProfileMenuItem::newPageContent() should be compatible with PhabricatorProfileMenuItem::newPageContent(PhabricatorProfileMenuItemConfiguration $config) at [/var/www/html/dev/core/lib/phabricator/src/applications/home/menuitem/PhabricatorHomeProfileMenuItem.php:68]
arcanist(head=master, ref.master=ade25facfdf2), corgi(head=master, ref.master=aebec8206183), instances(head=master, ref.master=0ddfd7990f6e), libcore(), phabricator(head=profile-redesign, ref.master=7e3adb1257af, ref.profile-redesign=18142be79de9), phutil(head=master, ref.master=9d85dfab0f53), services(head=master, ref.master=b5cef1ac31ff)
  #0 PhutilBootloader::executeInclude called at [<phutil>/src/moduleutils/PhutilBootloader.php:226]
  #1 PhutilBootloader::executeInclude(string) called at [<phutil>/src/moduleutils/PhutilBootloader.php:216]
  #2 PhutilBootloader::loadLibrarySource(string, string) called at [<phutil>/src/symbols/PhutilSymbolLoader.php:381]
  #3 PhutilSymbolLoader::loadSymbol(array) called at [<phutil>/src/symbols/PhutilSymbolLoader.php:256]
  #4 PhutilSymbolLoader::selectAndLoadSymbols() called at [<phutil>/src/__phutil_library_init__.php:22]
  #5 __phutil_autoload(string)
  #6 spl_autoload_call(string)
  #7 ReflectionClass::__construct(string) called
chad edited the test plan for this revision. (Show Details)Thu, Feb 2, 5:26 AM
epriestley accepted this revision.Thu, Feb 2, 2:37 PM

This feels a little weird to me at first glance, but I'll probably get used to it.

Is mobile generating an empty, invisible item at the top of the menu? It looks like there's too much space:

This revision is now accepted and ready to land.Thu, Feb 2, 2:37 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Thu, Feb 2, 6:33 PM

I poked at the extra menu item a bit and didn't see a non-hacky way forward. I'll poke at it again in a follow up.