Page MenuHomePhabricator

Add a "Needs Verification" state to Audit
ClosedPublic

Authored by epriestley on Jan 25 2017, 8:21 PM.
Tags
None
Referenced Files
F19607673: D17252.id.diff
Tue, Feb 3, 11:54 AM
F19561748: D17252.diff
Sat, Jan 31, 11:23 AM
F19051717: D17252.diff
Nov 28 2025, 1:36 AM
F19050344: D17252.diff
Nov 27 2025, 7:44 PM
F18840564: D17252.id41489.diff
Oct 28 2025, 2:20 AM
F18836854: D17252.diff
Oct 27 2025, 3:44 AM
F18834935: D17252.id.diff
Oct 26 2025, 12:03 PM
F18832200: D17252.diff
Oct 25 2025, 8:07 PM
Subscribers
None

Details

Summary

Fixes T2393. This allows authors to explicitly say "I think I fixed everything, please accept my commit now thank you".

Also improves behavior of "re-accept" and "re-reject" after new auditors you have authority over get added.

Test Plan
  • Kicked a commit back and forth between an author and auditor by alternately using "Request Verification" and "Raise Concern".
  • Verified it showed up properly in bucketing for both users.
  • Accepted, added a project, accepted again (works now; didn't before).
  • Audited on behalf of projects / packages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable