Page MenuHomePhabricator

Add a "Needs Verification" state to Audit
ClosedPublic

Authored by epriestley on Jan 25 2017, 8:21 PM.
Tags
None
Referenced Files
F15464863: D17252.id41494.diff
Wed, Apr 2, 12:57 PM
F15457753: D17252.diff
Sun, Mar 30, 6:27 PM
F15452447: D17252.diff
Sat, Mar 29, 4:52 AM
F15428973: D17252.id.diff
Sun, Mar 23, 11:49 PM
F15427031: D17252.id41494.diff
Sun, Mar 23, 12:15 PM
F15416111: D17252.id41494.diff
Thu, Mar 20, 9:19 AM
F15403495: D17252.id41494.diff
Tue, Mar 18, 3:35 AM
F15377448: D17252.id41489.diff
Mar 13 2025, 8:54 AM
Subscribers
None

Details

Summary

Fixes T2393. This allows authors to explicitly say "I think I fixed everything, please accept my commit now thank you".

Also improves behavior of "re-accept" and "re-reject" after new auditors you have authority over get added.

Test Plan
  • Kicked a commit back and forth between an author and auditor by alternately using "Request Verification" and "Raise Concern".
  • Verified it showed up properly in bucketing for both users.
  • Accepted, added a project, accepted again (works now; didn't before).
  • Audited on behalf of projects / packages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable