Page MenuHomePhabricator

Add a "Needs Verification" state to Audit
ClosedPublic

Authored by epriestley on Jan 25 2017, 8:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 11:24 AM
Unknown Object (File)
Sat, Dec 14, 4:53 AM
Unknown Object (File)
Thu, Dec 12, 4:22 AM
Unknown Object (File)
Tue, Dec 10, 9:20 AM
Unknown Object (File)
Fri, Dec 6, 12:25 PM
Unknown Object (File)
Thu, Dec 5, 10:10 AM
Unknown Object (File)
Tue, Dec 3, 8:10 AM
Unknown Object (File)
Tue, Nov 26, 12:17 PM
Subscribers
None

Details

Summary

Fixes T2393. This allows authors to explicitly say "I think I fixed everything, please accept my commit now thank you".

Also improves behavior of "re-accept" and "re-reject" after new auditors you have authority over get added.

Test Plan
  • Kicked a commit back and forth between an author and auditor by alternately using "Request Verification" and "Raise Concern".
  • Verified it showed up properly in bucketing for both users.
  • Accepted, added a project, accepted again (works now; didn't before).
  • Audited on behalf of projects / packages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable