Page MenuHomePhabricator

Add a "Needs Verification" state to Audit
ClosedPublic

Authored by epriestley on Jan 25 2017, 8:21 PM.
Tags
None
Referenced Files
F15527067: D17252.id41494.diff
Tue, Apr 22, 12:23 AM
F15525990: D17252.id41489.diff
Mon, Apr 21, 6:21 PM
F15518162: D17252.id.diff
Sat, Apr 19, 11:30 AM
F15516549: D17252.diff
Fri, Apr 18, 7:38 PM
F15464863: D17252.id41494.diff
Apr 2 2025, 12:57 PM
F15457753: D17252.diff
Mar 30 2025, 6:27 PM
F15452447: D17252.diff
Mar 29 2025, 4:52 AM
F15428973: D17252.id.diff
Mar 23 2025, 11:49 PM
Subscribers
None

Details

Summary

Fixes T2393. This allows authors to explicitly say "I think I fixed everything, please accept my commit now thank you".

Also improves behavior of "re-accept" and "re-reject" after new auditors you have authority over get added.

Test Plan
  • Kicked a commit back and forth between an author and auditor by alternately using "Request Verification" and "Raise Concern".
  • Verified it showed up properly in bucketing for both users.
  • Accepted, added a project, accepted again (works now; didn't before).
  • Audited on behalf of projects / packages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable