Page MenuHomePhabricator

Add a "Needs Verification" state to Audit
ClosedPublic

Authored by epriestley on Jan 25 2017, 8:21 PM.
Tags
None
Referenced Files
F18096136: D17252.id41494.diff
Fri, Aug 8, 4:42 AM
F18092910: D17252.id41489.diff
Thu, Aug 7, 2:02 PM
F18086154: D17252.id41489.diff
Tue, Aug 5, 7:42 PM
F18008283: D17252.id.diff
Sat, Aug 2, 2:34 PM
F17989112: D17252.diff
Fri, Aug 1, 11:39 PM
F17908727: D17252.id41494.diff
Tue, Jul 29, 1:57 PM
F17908529: D17252.diff
Tue, Jul 29, 1:51 PM
Unknown Object (File)
Jun 18 2025, 2:45 AM
Subscribers
None

Details

Summary

Fixes T2393. This allows authors to explicitly say "I think I fixed everything, please accept my commit now thank you".

Also improves behavior of "re-accept" and "re-reject" after new auditors you have authority over get added.

Test Plan
  • Kicked a commit back and forth between an author and auditor by alternately using "Request Verification" and "Raise Concern".
  • Verified it showed up properly in bucketing for both users.
  • Accepted, added a project, accepted again (works now; didn't before).
  • Audited on behalf of projects / packages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable