Page MenuHomePhabricator

Minor consistency/order updates for menu items which reference other objects
ClosedPublic

Authored by epriestley on Jan 20 2017, 7:44 PM.

Details

Summary

See T11957#208140.

  • Let Applications have a custom name, like other object items (for example, so you can call Maniphest "Tasks" if you prefer).
  • Put the optional name field after the required typeahead field for these items.
    • (I left "Link" in "Name, URI" order since both are required, but there's maybe an argument for swapping them?)
Test Plan
  • Created each type of item, saw "thing, name" order.
  • Created an application with a cusotm name, saw custom name.
  • Removed custom name, saw original name.

Diff Detail

Repository
rP Phabricator
Branch
item2
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 15340
Build 20197: Run Core Tests
Build 20196: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 20 2017, 7:44 PM
chad accepted this revision.Jan 20 2017, 7:50 PM

The main reason I hadn't done the app name thing yet was because I planned to look into alternate names when I redo Home. I don't know if this is in addition to maybe having a "menu item name" per application or just sidesteps us renaming them. I don't know if that option you suggested was still on the table. Maybe we talked about this in person, I can't recall.

This revision is now accepted and ready to land.Jan 20 2017, 7:50 PM

I think this is reasonable to have even if we rename since it costs us ~nothing and adds some flexibility. I think broader renaming is still on the table; we could do "light" renames, like one of these:

  • Make the default items, only, use the 'name' property to rename the "Differential" item to "Code Review".
  • Let applications have one real name, and a different name when they appear as a menu item.
  • (If we ever go back to the full-width menus we could do fancier title/subtitle/presentation stuff, maybe, but I'm not sure where design is headed on this.)

We could also do more aggressive renames but we're probably signing up for a lot of pain if we try to change names in URIs (like /differential/ to /codereview/) or Conduit (like differential.revision.search to codereview.revision.search).

chad added a comment.Jan 20 2017, 7:56 PM

Oh I guess we can pre set the names in code as bulletins here.

This revision was automatically updated to reflect the committed changes.