Page MenuHomePhabricator
Differential D17217

Fix MenuItem names not getting attached
ClosedPublic
Actions

Authored by chad on Jan 18 2017, 3:16 AM.
Tags
None
Referenced Files
F18836133: D17217.id.diff
Oct 26 2025, 10:29 PM
F18832271: D17217.diff
Oct 25 2025, 9:02 PM
F18791708: D17217.id41414.diff
Oct 16 2025, 5:02 PM
F18772819: D17217.id.diff
Oct 9 2025, 4:59 AM
F18756722: D17217.id41413.diff
Oct 5 2025, 1:04 PM
F18729486: D17217.diff
Sep 30 2025, 11:13 AM
F18629355: D17217.diff
Sep 16 2025, 8:35 AM
F18618336: D17217.diff
Sep 14 2025, 11:49 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T12116: Edit Form page doesn't show Form names
Commits
rP2d4eb460abb2: Fix MenuItem names not getting attached
Summary
  • Attach objects when showing configuration screen
  • Fix "Forms" to make more sense
  • Alter EditEngine title to load correct name by loading object

Fixes T12116

Test Plan

Load up Apps/Projects/Forms on a configure menu, see proper names

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
search/
editor/
1 line
engine/
6 lines
menuitem/
2 lines

Diff 41414

View Options

src/applications/search/editor/PhabricatorProfileMenuEditEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Loading...
View Options

src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php

Loading...
Phabricator · Built by Phacility