Page MenuHomePhabricator
Differential D17217

Fix MenuItem names not getting attached
ClosedPublic
Actions

Authored by chad on Jan 18 2017, 3:16 AM.
Tags
None
Referenced Files
F18109854: D17217.id41414.diff
Mon, Aug 11, 3:22 PM
F18109852: D17217.id41413.diff
Mon, Aug 11, 3:22 PM
F18109851: D17217.id.diff
Mon, Aug 11, 3:22 PM
F18104622: D17217.diff
Sun, Aug 10, 1:31 PM
F18086948: D17217.id41413.diff
Wed, Aug 6, 1:20 AM
F18086466: D17217.id41414.diff
Tue, Aug 5, 10:04 PM
F18051233: D17217.id41413.diff
Sun, Aug 3, 10:35 PM
F17840933: D17217.id.diff
Sat, Jul 26, 9:43 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T12116: Edit Form page doesn't show Form names
Commits
rP2d4eb460abb2: Fix MenuItem names not getting attached
Summary
  • Attach objects when showing configuration screen
  • Fix "Forms" to make more sense
  • Alter EditEngine title to load correct name by loading object

Fixes T12116

Test Plan

Load up Apps/Projects/Forms on a configure menu, see proper names

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
search/
editor/
1 line
engine/
6 lines
menuitem/
2 lines

Diff 41414

View Options

src/applications/search/editor/PhabricatorProfileMenuEditEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Loading...
View Options

src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php

Loading...
Phabricator · Built by Phacility