Page MenuHomePhabricator
Differential D17213

Load global and custom profile menu items in a single query
ClosedPublic
Actions

Authored by epriestley on Jan 17 2017, 8:49 PM.
Tags
None
Referenced Files
F14494213: D17213.id41405.diff
Fri, Jan 3, 4:51 AM
Unknown Object (File)
Tue, Dec 17, 8:01 AM
Unknown Object (File)
Fri, Dec 13, 5:58 PM
Unknown Object (File)
Dec 3 2024, 5:37 PM
Unknown Object (File)
Nov 28 2024, 12:35 AM
Unknown Object (File)
Nov 19 2024, 8:24 PM
Unknown Object (File)
Nov 16 2024, 7:20 AM
Unknown Object (File)
Nov 12 2024, 3:51 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T5867: Move Quick Create to MenuItemEngine
Commits
rPd7e5a8b978ad: Load global and custom profile menu items in a single query
Summary

Ref T5867. Use a single query to load both personal and global items, then reorder them and add a divider if both groups have some stuff.

Test Plan

Viewed menu, edited personal and global items, viewed/edited existing project menus.

Diff Detail

Repository
rP Phabricator
Branch
menu1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15293
Build 20125: Run Core Tests
Build 20124: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 17 2017, 8:49 PM
Harbormaster completed remote builds in B15293: Diff 41404.Jan 17 2017, 8:50 PM
chad edited edge metadata.Jan 17 2017, 8:52 PM

oh yea, so easy

magicb41e5.gif (307×570 px, 7 MB)

chad accepted this revision.Jan 17 2017, 8:54 PM
This revision is now accepted and ready to land.Jan 17 2017, 8:54 PM
epriestley added a comment.Jan 17 2017, 9:02 PM

The builtin stuff made this a bit more involved than I imagined, yeah.

Closed by commit rPd7e5a8b978ad: Load global and custom profile menu items in a single query (authored by epriestley, committed by epriestley). · Explain WhyJan 17 2017, 9:02 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Jan 17 2017, 9:04 PM

Also, any clue where this came from?

Screen Shot 2017-01-17 at 1.04.32 PM.png (164×148 px, 10 KB)

chad added a comment.Jan 17 2017, 9:17 PM

Hmm I didn't see it in my testing but probably still me. Will look soon (getting MacBook fixed)

epriestley added a comment.Jan 17 2017, 9:35 PM

Also, why is the label in the user menu the Real Name, but log out still says "Log out <username>"?

chad added a comment.Jan 17 2017, 10:01 PM

I haven't built the final version yet. This diff was getting long in the tooth. I think I commented above? I have more plans for UI.

epriestley added a comment.Jan 17 2017, 10:01 PM

Ah, must have missed it.

chad added a comment.Jan 17 2017, 10:05 PM

I think I need to convert PhabricatorActionView to a proper AphrontTagView, and migrate setMetadata globally to be able to fully customize the UI there. Brings us closer to PHUIListItemView as well.

Revision Contents
Changeset List

Diff 41404

View Options

src/applications/favorites/application/PhabricatorFavoritesApplication.php

Loading...
View Options

src/applications/favorites/engine/PhabricatorFavoritesProfileMenuEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Loading...
View Options

src/applications/search/query/PhabricatorProfileMenuItemConfigurationQuery.php

Loading...
View Options

src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php

Loading...
Phabricator · Built by Phacility