Page MenuHomePhabricator

Explicitly warn the user multiple times when they try to register an external account with an existing email

Authored by epriestley on Jan 17 2017, 7:26 PM.



Ref T3472. Ref T12113. This implements the gigantic roadblock nonsense in T3472.

Test Plan

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 17 2017, 7:26 PM
chad accepted this revision.Jan 17 2017, 7:29 PM
This revision is now accepted and ready to land.Jan 17 2017, 7:29 PM

We could possibly improve this flow by giving users a modal choice ("link existing" or "create new") instead of this roadblock dialog ("stop, go do it right" or "create new"), but we'd need to put more handholding along the "link existing" flow because the user must login (and go through MFA, if applicable) before we can safely link accounts: it is not safe to link accounts just because a user knows the credential of some external account with the same email address.

This flow is rare anyway, and this roadblock mostly saves us from spending 2+ hours failing to reproduce LDAP issues in the future (T12113).

This revision was automatically updated to reflect the committed changes.
kugel- added a subscriber: kugel-.Jan 17 2017, 8:24 PM

Just for the record, this change works for me. Many thanks for quickly resolving my problem!