Ref T3472. Ref T12113. This implements the gigantic roadblock nonsense in T3472.
- Maniphest Tasks
- Restricted Maniphest Task
T12113: Email in LDAP registration form is empty
- rP23721799fd0b: Explicitly warn the user multiple times when they try to register an external…
We could possibly improve this flow by giving users a modal choice ("link existing" or "create new") instead of this roadblock dialog ("stop, go do it right" or "create new"), but we'd need to put more handholding along the "link existing" flow because the user must login (and go through MFA, if applicable) before we can safely link accounts: it is not safe to link accounts just because a user knows the credential of some external account with the same email address.
This flow is rare anyway, and this roadblock mostly saves us from spending 2+ hours failing to reproduce LDAP issues in the future (T12113).