Page MenuHomePhabricator

Remove some remnants of the old ways commit mesage fields worked from Differential
ClosedPublic

Authored by epriestley on Jan 13 2017, 11:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 17 2024, 10:46 PM
Unknown Object (File)
Feb 11 2024, 11:17 AM
Unknown Object (File)
Feb 3 2024, 2:02 PM
Unknown Object (File)
Jan 28 2024, 2:35 AM
Unknown Object (File)
Jan 28 2024, 1:12 AM
Unknown Object (File)
Jan 24 2024, 11:45 PM
Unknown Object (File)
Jan 17 2024, 8:03 AM
Unknown Object (File)
Dec 27 2023, 9:27 AM
Subscribers
None

Details

Summary

Ref T11114. Ref T12085. I missed a few pieces of cleanup when moving all this stuff over.

In particular, load all fields which use Custom Field storage before doing commit-message-related stuff, instead of just the ones that claim they appear on commit messages.

Test Plan

Edited revisions and made API calls without apparent issues. See followup on T12085, shortly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 13 2017, 11:21 PM
  • Get rid of slightly more cruft.
  • Don't send my hilarious "you will be fired" suggestion upstream.

I'm only like 95% sure all this code was actually completely unused, so yell if you catch anything weird. It's supposed to be unused, though.

This revision was automatically updated to reflect the committed changes.