Never really used this to full potential and takes up a lot of code and space. Remove option for now and make all profile nav menus small by default.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T5867: Move Quick Create to MenuItemEngine
- Commits
- rP36e53fd5d010: Remove collapsable option from ProfileMenu
Review user, project, workboard. Set new menus.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- no-profile-menu (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 15257 Build 20061: Run Core Tests Build 20060: arc lint + arc unit
Event Timeline
Comment Actions
I'd personally get rid of the collapsed mode, not the expanded mode, but don't feel too strongly about it.
Comment Actions
I left the variables in just in case we go back. I'll probably look at it when I do the home side menu
Comment Actions
Yeah, all I can think of for actual issues is that it limits our ability to do richer elements like some of the stuff in older mocks, and we don't have much room to put a "(6) Open Revisions" sort of notification counter or anything anymore. Not sure those are really important, though.
Comment Actions
Yeah, I'm not sure how to do counts with ProfileMenuItem, pretty sure people will miss those.
Comment Actions
We could maybe do some kind of Dashboard panel thing instead, although I can't immediately come up with a design that isn't huge to the point of being obnoxious. I don't personally use the counts since they're all at like 95 million billion for me ("Assigned Tasks" lul), but I assume we'll see at least some pushback. The audit count (which I removed until we figure out what's going on) may actually be somewhat useful soon, too.
Comment Actions
Whatever we do on home, will also work for projects... unsure about profiles.... maybe ? Only leaves workboards hanging though, but maybe with fullscreen that really isn't an issue.