Page MenuHomePhabricator

Remove collapsable option from ProfileMenu
ClosedPublic

Authored by chad on Jan 13 2017, 10:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:07 AM
Unknown Object (File)
Fri, Apr 19, 6:06 PM
Unknown Object (File)
Wed, Apr 10, 3:18 PM
Unknown Object (File)
Sat, Apr 6, 3:40 PM
Unknown Object (File)
Wed, Apr 3, 5:07 PM
Unknown Object (File)
Sat, Mar 30, 4:34 PM
Unknown Object (File)
Mar 24 2024, 9:19 PM
Unknown Object (File)
Mar 20 2024, 10:41 PM
Subscribers

Details

Summary

Never really used this to full potential and takes up a lot of code and space. Remove option for now and make all profile nav menus small by default.

Test Plan

Review user, project, workboard. Set new menus.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I'd personally get rid of the collapsed mode, not the expanded mode, but don't feel too strongly about it.

This revision is now accepted and ready to land.Jan 13 2017, 10:42 PM

I left the variables in just in case we go back. I'll probably look at it when I do the home side menu

Yeah, all I can think of for actual issues is that it limits our ability to do richer elements like some of the stuff in older mocks, and we don't have much room to put a "(6) Open Revisions" sort of notification counter or anything anymore. Not sure those are really important, though.

Yeah, I'm not sure how to do counts with ProfileMenuItem, pretty sure people will miss those.

We could maybe do some kind of Dashboard panel thing instead, although I can't immediately come up with a design that isn't huge to the point of being obnoxious. I don't personally use the counts since they're all at like 95 million billion for me ("Assigned Tasks" lul), but I assume we'll see at least some pushback. The audit count (which I removed until we figure out what's going on) may actually be somewhat useful soon, too.

This revision was automatically updated to reflect the committed changes.

Whatever we do on home, will also work for projects... unsure about profiles.... maybe ? Only leaves workboards hanging though, but maybe with fullscreen that really isn't an issue.