Improve commit audit status icons
ClosedPublic
Actions

Authored by epriestley on Jan 13 2017, 12:33 AM.

Tags

None

Referenced Files

	F19541697: D17203.id41364.diff
	Thu, Jan 22, 6:37 AM

	F19524963: D17203.id.diff
	Sun, Jan 18, 5:12 AM

	F19524962: D17203.id.diff
	Sun, Jan 18, 5:12 AM

	F19521146: D17203.diff
	Fri, Jan 16, 7:52 PM

	F19520609: D17203.id41363.diff
	Fri, Jan 16, 3:21 PM

	F19518301: D17203.diff
	Thu, Jan 15, 7:22 PM

	F19517753: D17203.id41363.diff
	Thu, Jan 15, 3:04 PM

	F19513919: D17203.diff
	Tue, Jan 13, 7:35 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T9482: Problems in the "Commits in this Package that Need Attention" view

Commits

rP4d0a03e3d0b2: Improve commit audit status icons

Summary

Ref T9482. These may need a little more work (feel free to shoot me a counter-diff) but try to:

Never use only color to distinguish between states (for colorblind, etc users).
Give the "nothing needs to be done" state a more obvious "okay" icon (instead of a question mark).

Test Plan

Looked at some linked commits in Maniphest, the icons made a bit more sense?

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 13 2017, 12:33 AM

chad accepted this revision.Jan 13 2017, 12:34 AM

This revision is now accepted and ready to land.Jan 13 2017, 12:34 AM

Harbormaster completed remote builds in B15251: Diff 41363.Jan 13 2017, 12:34 AM

Closed by commit rP4d0a03e3d0b2: Improve commit audit status icons (authored by epriestley, committed by epriestley). · Explain WhyJan 13 2017, 12:35 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

constants/

PhabricatorAuditCommitStatusConstants.php

14 lines

Diff 41364

View Options

src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php

Improve commit audit status iconsClosedPublicActions