Page MenuHomePhabricator

Improve commit audit status icons
ClosedPublic

Authored by epriestley on Jan 13 2017, 12:33 AM.
Tags
None
Referenced Files
F18784435: D17203.id41363.diff
Mon, Oct 13, 12:31 PM
F18784434: D17203.id.diff
Mon, Oct 13, 12:31 PM
F18784433: D17203.id41364.diff
Mon, Oct 13, 12:31 PM
F18784373: D17203.diff
Mon, Oct 13, 12:24 PM
F18779052: D17203.id.diff
Sat, Oct 11, 11:47 AM
F18752711: D17203.id41363.diff
Sat, Oct 4, 4:10 PM
F18717037: D17203.diff
Sep 29 2025, 1:06 PM
F18628364: D17203.id41364.diff
Sep 16 2025, 6:13 AM
Subscribers
None

Details

Summary

Ref T9482. These may need a little more work (feel free to shoot me a counter-diff) but try to:

  • Never use only color to distinguish between states (for colorblind, etc users).
  • Give the "nothing needs to be done" state a more obvious "okay" icon (instead of a question mark).
Test Plan

Looked at some linked commits in Maniphest, the icons made a bit more sense?

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 13 2017, 12:34 AM
This revision was automatically updated to reflect the committed changes.