Page MenuHomePhabricator

Improve commit audit status icons
ClosedPublic

Authored by epriestley on Jan 13 2017, 12:33 AM.
Tags
None
Referenced Files
F15461055: D17203.id.diff
Tue, Apr 1, 4:48 AM
F15453485: D17203.diff
Sat, Mar 29, 12:10 PM
F15453319: D17203.id41363.diff
Sat, Mar 29, 10:53 AM
F15445663: D17203.diff
Thu, Mar 27, 3:21 PM
F15415554: D17203.id41364.diff
Thu, Mar 20, 6:38 AM
F15401314: D17203.id41363.diff
Mon, Mar 17, 4:57 PM
F15400681: D17203.id41363.diff
Mon, Mar 17, 1:19 PM
F15397121: D17203.id41364.diff
Sun, Mar 16, 6:16 PM
Subscribers
None

Details

Summary

Ref T9482. These may need a little more work (feel free to shoot me a counter-diff) but try to:

  • Never use only color to distinguish between states (for colorblind, etc users).
  • Give the "nothing needs to be done" state a more obvious "okay" icon (instead of a question mark).
Test Plan

Looked at some linked commits in Maniphest, the icons made a bit more sense?

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 13 2017, 12:34 AM
This revision was automatically updated to reflect the committed changes.