Page MenuHomePhabricator

Improve commit audit status icons
ClosedPublic

Authored by epriestley on Jan 13 2017, 12:33 AM.
Tags
None
Referenced Files
F19906737: D17203.diff
Wed, Apr 1, 3:49 AM
F19875010: D17203.id.diff
Mar 16 2026, 1:02 AM
F19826623: D17203.diff
Mar 8 2026, 11:02 PM
F19823887: D17203.id41364.diff
Mar 7 2026, 4:32 PM
F19541697: D17203.id41364.diff
Jan 22 2026, 6:37 AM
F19524963: D17203.id.diff
Jan 18 2026, 5:12 AM
F19524962: D17203.id.diff
Jan 18 2026, 5:12 AM
F19521146: D17203.diff
Jan 16 2026, 7:52 PM
Subscribers
None

Details

Summary

Ref T9482. These may need a little more work (feel free to shoot me a counter-diff) but try to:

  • Never use only color to distinguish between states (for colorblind, etc users).
  • Give the "nothing needs to be done" state a more obvious "okay" icon (instead of a question mark).
Test Plan

Looked at some linked commits in Maniphest, the icons made a bit more sense?

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 13 2017, 12:34 AM
This revision was automatically updated to reflect the committed changes.