Page MenuHomePhabricator

Improve commit audit status icons
ClosedPublic

Authored by epriestley on Jan 13 2017, 12:33 AM.
Tags
None
Referenced Files
F15559752: D17203.id41364.diff
Tue, Apr 29, 10:19 AM
F15542166: D17203.id41363.diff
Fri, Apr 25, 4:07 PM
F15538730: D17203.id41364.diff
Thu, Apr 24, 9:12 PM
F15527712: D17203.id41364.diff
Tue, Apr 22, 6:04 AM
F15518179: D17203.id41364.diff
Sat, Apr 19, 11:43 AM
F15507772: D17203.id41363.diff
Tue, Apr 15, 10:40 PM
F15506309: D17203.id41364.diff
Tue, Apr 15, 10:06 AM
F15503671: D17203.id.diff
Mon, Apr 14, 12:01 PM
Subscribers
None

Details

Summary

Ref T9482. These may need a little more work (feel free to shoot me a counter-diff) but try to:

  • Never use only color to distinguish between states (for colorblind, etc users).
  • Give the "nothing needs to be done" state a more obvious "okay" icon (instead of a question mark).
Test Plan

Looked at some linked commits in Maniphest, the icons made a bit more sense?

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 13 2017, 12:34 AM
This revision was automatically updated to reflect the committed changes.