Stop hardcoding the YACC error message
ClosedPublic
Actions

Authored by alexmv on Jan 12 2017, 3:26 PM.

Tags

None

Referenced Files

	F15454308: D17189.id41334.diff
	Sat, Mar 29, 5:51 PM

	F15450739: D17189.id.diff
	Fri, Mar 28, 5:52 PM

	F15445001: D17189.diff
	Thu, Mar 27, 12:15 PM

	F15404818: D17189.diff
	Tue, Mar 18, 9:15 AM

	F15379877: D17189.id.diff
	Thu, Mar 13, 11:52 PM

	F15376256: D17189.diff
	Thu, Mar 13, 2:33 AM

	F15286097: D17189.diff
	Mar 4 2025, 6:12 PM

	Unknown Object (File)
	Feb 21 2025, 3:03 PM

View All Files

Subscribers

epriestley

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUe4b06e06ee78: Stop hardcoding the YACC error message

Summary

The exact syntax of the error varies with YACC version.

Ref D17188#204123.

Test Plan

Unit tests.

Diff Detail

Repository

rPHU libphutil

Branch

up-yacc-iniparser

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15221
Build 20007: Run Core Tests
Build 20006: arc lint + arc unit

Event Timeline

alexmv created this revision.Jan 12 2017, 3:26 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 12 2017, 3:26 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster failed remote builds in B15221: Diff 41334!Jan 12 2017, 3:26 PM

Harbormaster failed remote builds in B15221: Diff 41334!

Oh, this didn't push to staging which is why the build isn't working; T10093. Change is fine anyway.

This revision is now accepted and ready to land.Jan 12 2017, 3:27 PM

alexmv closed this revision.Jan 12 2017, 3:30 PM

Revision Contents
Changeset List

Path

Size

src/

utils/

__tests__/

PhutilUtilsTestCase.php

6 lines

Diff 41334

View Options

src/utils/tests/PhutilUtilsTestCase.php

Stop hardcoding the YACC error messageClosedPublicActions