Stop hardcoding the YACC error message
ClosedPublic
Actions

Authored by alexmv on Jan 12 2017, 3:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 20, 8:22 AM

	Unknown Object (File)
	Fri, Nov 15, 5:54 PM

	Unknown Object (File)
	Tue, Nov 12, 2:37 AM

	Unknown Object (File)
	Sat, Nov 9, 4:42 PM

	Unknown Object (File)
	Sat, Nov 9, 4:33 PM

	Unknown Object (File)
	Thu, Nov 7, 7:45 PM

	Unknown Object (File)
	Oct 24 2024, 9:24 AM

	Unknown Object (File)
	Oct 21 2024, 11:18 PM

View All Files

Subscribers

epriestley

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUe4b06e06ee78: Stop hardcoding the YACC error message

Summary

The exact syntax of the error varies with YACC version.

Ref D17188#204123.

Test Plan

Unit tests.

Diff Detail

Repository

rPHU libphutil

Branch

up-yacc-iniparser

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15221
Build 20007: Run Core Tests
Build 20006: arc lint + arc unit

Event Timeline

alexmv created this revision.Jan 12 2017, 3:26 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 12 2017, 3:26 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster failed remote builds in B15221: Diff 41334!Jan 12 2017, 3:26 PM

Harbormaster failed remote builds in B15221: Diff 41334!

Oh, this didn't push to staging which is why the build isn't working; T10093. Change is fine anyway.

This revision is now accepted and ready to land.Jan 12 2017, 3:27 PM

alexmv closed this revision.Jan 12 2017, 3:30 PM

Revision Contents
Changeset List

Path

Size

src/

utils/

__tests__/

PhutilUtilsTestCase.php

6 lines

Diff 41334

View Options

src/utils/tests/PhutilUtilsTestCase.php

Stop hardcoding the YACC error messageClosedPublicActions