Page MenuHomePhabricator

Force 'changes' to a string in hunk migration
ClosedPublic

Authored by epriestley on Jan 10 2017, 7:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 10:52 AM
Unknown Object (File)
Sat, Jan 25, 7:10 AM
Unknown Object (File)
Wed, Jan 22, 9:33 PM
Unknown Object (File)
Wed, Jan 22, 9:19 PM
Unknown Object (File)
Sat, Jan 18, 7:30 AM
Unknown Object (File)
Sun, Jan 12, 10:26 AM
Unknown Object (File)
Sun, Jan 12, 7:26 AM
Unknown Object (File)
Mon, Jan 6, 5:20 PM
Subscribers
None

Details

Summary

Fixes T12090. In obscure situations lost to the mists of time, the changes column could be null. Force a string cast so the migration finishes, even though these changesets are likely meaningless.

Test Plan

I did a force-reapply as a sanity check:

$ ./bin/storage upgrade -f --apply phabricator:20161213.diff.01.hunks.php 

That went cleanly; it would only have caught dramatic errors, but I didn't completely butcher things.

Diff Detail

Repository
rP Phabricator
Branch
robust1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15178
Build 19941: Run Core Tests
Build 19940: arc lint + arc unit