Page MenuHomePhabricator

Force 'changes' to a string in hunk migration
ClosedPublic

Authored by epriestley on Jan 10 2017, 7:55 PM.
Tags
None
Referenced Files
F18029262: D17168.id41291.diff
Aug 2 2025, 11:12 PM
F18011262: D17168.id41293.diff
Aug 2 2025, 4:11 PM
F17922214: D17168.diff
Jul 30 2025, 6:27 AM
F17915665: D17168.id.diff
Jul 29 2025, 8:55 PM
F17889630: D17168.diff
Jul 29 2025, 2:48 AM
F17888070: D17168.id41293.diff
Jul 29 2025, 1:58 AM
F17883758: D17168.diff
Jul 28 2025, 11:33 PM
F17880736: D17168.diff
Jul 28 2025, 9:40 PM
Subscribers
None

Details

Summary

Fixes T12090. In obscure situations lost to the mists of time, the changes column could be null. Force a string cast so the migration finishes, even though these changesets are likely meaningless.

Test Plan

I did a force-reapply as a sanity check:

$ ./bin/storage upgrade -f --apply phabricator:20161213.diff.01.hunks.php 

That went cleanly; it would only have caught dramatic errors, but I didn't completely butcher things.

Diff Detail

Repository
rP Phabricator
Branch
robust1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15178
Build 19941: Run Core Tests
Build 19940: arc lint + arc unit