Page MenuHomePhabricator

Force 'changes' to a string in hunk migration
ClosedPublic

Authored by epriestley on Jan 10 2017, 7:55 PM.
Tags
None
Referenced Files
F15430552: D17168.id41293.diff
Mon, Mar 24, 8:07 AM
F15389525: D17168.id41293.diff
Sat, Mar 15, 5:22 AM
F15380817: D17168.diff
Fri, Mar 14, 4:37 AM
F15377923: D17168.id41293.diff
Thu, Mar 13, 11:25 AM
F15325157: D17168.diff
Fri, Mar 7, 2:18 AM
Unknown Object (File)
Mon, Mar 3, 2:32 PM
Unknown Object (File)
Thu, Feb 27, 4:38 PM
Unknown Object (File)
Feb 21 2025, 3:02 PM
Subscribers
None

Details

Summary

Fixes T12090. In obscure situations lost to the mists of time, the changes column could be null. Force a string cast so the migration finishes, even though these changesets are likely meaningless.

Test Plan

I did a force-reapply as a sanity check:

$ ./bin/storage upgrade -f --apply phabricator:20161213.diff.01.hunks.php 

That went cleanly; it would only have caught dramatic errors, but I didn't completely butcher things.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable