Page MenuHomePhabricator

Force 'changes' to a string in hunk migration
ClosedPublic

Authored by epriestley on Jan 10 2017, 7:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 29, 8:56 AM
Unknown Object (File)
Wed, May 7, 10:48 AM
Unknown Object (File)
Apr 27 2025, 9:50 PM
Unknown Object (File)
Apr 27 2025, 3:19 PM
Unknown Object (File)
Apr 25 2025, 7:52 PM
Unknown Object (File)
Apr 24 2025, 9:42 PM
Unknown Object (File)
Apr 12 2025, 3:00 AM
Unknown Object (File)
Mar 27 2025, 4:28 PM
Subscribers
None

Details

Summary

Fixes T12090. In obscure situations lost to the mists of time, the changes column could be null. Force a string cast so the migration finishes, even though these changesets are likely meaningless.

Test Plan

I did a force-reapply as a sanity check:

$ ./bin/storage upgrade -f --apply phabricator:20161213.diff.01.hunks.php 

That went cleanly; it would only have caught dramatic errors, but I didn't completely butcher things.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable