Page MenuHomePhabricator

Force 'changes' to a string in hunk migration
ClosedPublic

Authored by epriestley on Jan 10 2017, 7:55 PM.
Tags
None
Referenced Files
F19014458: D17168.id.diff
Sat, Nov 22, 8:08 PM
F18991541: D17168.diff
Tue, Nov 18, 10:29 PM
F18908648: D17168.id41291.diff
Sun, Nov 9, 1:19 AM
F18821238: D17168.id41293.diff
Oct 22 2025, 8:53 PM
F18794729: D17168.diff
Oct 17 2025, 12:34 AM
F18772081: D17168.id.diff
Oct 9 2025, 12:10 AM
F18669317: D17168.id.diff
Sep 24 2025, 8:01 PM
F18626023: D17168.diff
Sep 16 2025, 12:11 AM
Subscribers
None

Details

Summary

Fixes T12090. In obscure situations lost to the mists of time, the changes column could be null. Force a string cast so the migration finishes, even though these changesets are likely meaningless.

Test Plan

I did a force-reapply as a sanity check:

$ ./bin/storage upgrade -f --apply phabricator:20161213.diff.01.hunks.php 

That went cleanly; it would only have caught dramatic errors, but I didn't completely butcher things.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable