Page MenuHomePhabricator

Force 'changes' to a string in hunk migration
ClosedPublic

Authored by epriestley on Jan 10 2017, 7:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 6:02 PM
Unknown Object (File)
Wed, Apr 10, 3:41 PM
Unknown Object (File)
Sun, Apr 7, 10:27 AM
Unknown Object (File)
Sat, Mar 30, 1:17 AM
Unknown Object (File)
Thu, Mar 28, 10:18 AM
Unknown Object (File)
Mar 5 2024, 1:27 PM
Unknown Object (File)
Feb 24 2024, 5:12 PM
Unknown Object (File)
Jan 22 2024, 7:33 PM
Subscribers
None

Details

Summary

Fixes T12090. In obscure situations lost to the mists of time, the changes column could be null. Force a string cast so the migration finishes, even though these changesets are likely meaningless.

Test Plan

I did a force-reapply as a sanity check:

$ ./bin/storage upgrade -f --apply phabricator:20161213.diff.01.hunks.php 

That went cleanly; it would only have caught dramatic errors, but I didn't completely butcher things.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable