Page MenuHomePhabricator

Force 'changes' to a string in hunk migration
ClosedPublic

Authored by epriestley on Jan 10 2017, 7:55 PM.
Tags
None
Referenced Files
F14005100: D17168.id.diff
Sun, Oct 27, 7:22 AM
F13969579: D17168.id41291.diff
Oct 17 2024, 3:16 AM
F13955172: D17168.diff
Oct 14 2024, 12:24 AM
Unknown Object (File)
Oct 5 2024, 12:04 PM
Unknown Object (File)
Oct 5 2024, 11:36 AM
Unknown Object (File)
Oct 4 2024, 7:01 PM
Unknown Object (File)
Oct 1 2024, 8:59 AM
Unknown Object (File)
Sep 27 2024, 9:40 AM
Subscribers
None

Details

Summary

Fixes T12090. In obscure situations lost to the mists of time, the changes column could be null. Force a string cast so the migration finishes, even though these changesets are likely meaningless.

Test Plan

I did a force-reapply as a sanity check:

$ ./bin/storage upgrade -f --apply phabricator:20161213.diff.01.hunks.php 

That went cleanly; it would only have caught dramatic errors, but I didn't completely butcher things.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable