Page MenuHomePhabricator

When updating revisions in response to commits, reuse previously generated diffs
ClosedPublic

Authored by epriestley on Jan 9 2017, 7:45 PM.
Tags
None
Referenced Files
F15505145: D17164.id.diff
Tue, Apr 15, 12:04 AM
F15446645: D17164.id41278.diff
Thu, Mar 27, 7:39 PM
F15442546: D17164.id41276.diff
Wed, Mar 26, 11:47 PM
F15442545: D17164.id.diff
Wed, Mar 26, 11:47 PM
F15441578: D17164.diff
Wed, Mar 26, 6:51 PM
F15335123: D17164.id41276.diff
Mar 8 2025, 2:24 PM
Unknown Object (File)
Mar 3 2025, 1:22 PM
Unknown Object (File)
Feb 25 2025, 8:47 PM
Subscribers
None

Details

Summary

Fixes T10968. In rare situations, we can generate a diff, then hit an error which causes this update to fail.

When it does, we tend to get stuck in a loop creating diffs, which can fill the database up with garbage. We saw this once in the Phacility cluster, and one instance hit it, too.

Instead: when we create a diff, keep track of which commit we generated it from. The next time through, reuse it if we already built it.

Test Plan
  • Used bin/differential attach-commit <commit> <revision> to hit this code.
  • Simulated a filesystem write failure, saw the diff get reused.
  • Also did a normal update, which worked properly.

Diff Detail

Repository
rP Phabricator
Branch
diff1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15163
Build 19919: Run Core Tests
Build 19918: arc lint + arc unit