Page MenuHomePhabricator

Remove extra container tag on HandleListViews rendering from ModularTransactions in text mode
ClosedPublic

Authored by epriestley on Jan 9 2017, 4:19 PM.
Tags
None
Referenced Files
F14038559: D17162.id41270.diff
Mon, Nov 11, 12:24 AM
F14008830: D17162.diff
Wed, Oct 30, 6:43 AM
F13998995: D17162.diff
Thu, Oct 24, 12:15 PM
Unknown Object (File)
Sep 30 2024, 4:32 PM
Unknown Object (File)
Sep 24 2024, 2:36 AM
Unknown Object (File)
Sep 21 2024, 3:43 AM
Unknown Object (File)
Sep 18 2024, 1:20 PM
Unknown Object (File)
Sep 17 2024, 4:46 PM
Subscribers
None

Details

Summary

Fixes T12082. Ref T11114. When modular transaction render a handle list, they use HandleListView, which has a text mode.

However, the HandleListView is a TagView, and currently TagViews always render a tag of some kind. Allow them to return null to decline to render any tag.

Test Plan
  • Added a pile of debugging stuff to ApplicationTransactionEditor to throw during mail generation.
  • Added a reviewer to a revision.
  • Used bin/worker execute --id ... to hit the mail generation repeatedly.
  • Before patch: mail generated with a <span>, even in text mode.
  • After patch: clean mail generation.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable