Page MenuHomePhabricator

Remove extra container tag on HandleListViews rendering from ModularTransactions in text mode
ClosedPublic

Authored by epriestley on Jan 9 2017, 4:19 PM.
Tags
None
Referenced Files
F18627648: D17162.diff
Tue, Sep 16, 4:27 AM
F18622129: D17162.id41273.diff
Mon, Sep 15, 10:33 AM
F18519483: D17162.diff
Fri, Sep 5, 5:26 PM
F18508400: D17162.id.diff
Fri, Sep 5, 2:47 AM
F18500433: D17162.diff
Thu, Sep 4, 9:04 PM
F18093469: D17162.id41273.diff
Aug 7 2025, 6:36 PM
F18090920: D17162.id.diff
Aug 6 2025, 6:09 PM
F18086231: D17162.diff
Aug 5 2025, 8:14 PM
Subscribers
None

Details

Summary

Fixes T12082. Ref T11114. When modular transaction render a handle list, they use HandleListView, which has a text mode.

However, the HandleListView is a TagView, and currently TagViews always render a tag of some kind. Allow them to return null to decline to render any tag.

Test Plan
  • Added a pile of debugging stuff to ApplicationTransactionEditor to throw during mail generation.
  • Added a reviewer to a revision.
  • Used bin/worker execute --id ... to hit the mail generation repeatedly.
  • Before patch: mail generated with a <span>, even in text mode.
  • After patch: clean mail generation.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable