Page MenuHomePhabricator

Remove extra container tag on HandleListViews rendering from ModularTransactions in text mode
ClosedPublic

Authored by epriestley on Jan 9 2017, 4:19 PM.
Tags
None
Referenced Files
F18824646: D17162.id.diff
Thu, Oct 23, 5:01 PM
F18821947: D17162.diff
Thu, Oct 23, 3:00 AM
F18783559: D17162.id41270.diff
Mon, Oct 13, 8:04 AM
F18679576: D17162.diff
Fri, Sep 26, 1:00 AM
F18658541: D17162.id41270.diff
Sep 23 2025, 7:07 AM
F18652793: D17162.diff
Sep 21 2025, 9:34 AM
F18627648: D17162.diff
Sep 16 2025, 4:27 AM
F18622129: D17162.id41273.diff
Sep 15 2025, 10:33 AM
Subscribers
None

Details

Summary

Fixes T12082. Ref T11114. When modular transaction render a handle list, they use HandleListView, which has a text mode.

However, the HandleListView is a TagView, and currently TagViews always render a tag of some kind. Allow them to return null to decline to render any tag.

Test Plan
  • Added a pile of debugging stuff to ApplicationTransactionEditor to throw during mail generation.
  • Added a reviewer to a revision.
  • Used bin/worker execute --id ... to hit the mail generation repeatedly.
  • Before patch: mail generated with a <span>, even in text mode.
  • After patch: clean mail generation.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable