Page MenuHomePhabricator
Differential D17141

Bring up contrast on light green / red diffs
ClosedPublic
Actions

Authored by chad on Jan 4 2017, 10:37 PM.
Tags
None
Referenced Files
F19745714: D17141.diff
Sun, Feb 15, 4:18 PM
F19560444: D17141.id41223.diff
Sat, Jan 31, 7:28 AM
F19524912: D17141.id.diff
Jan 18 2026, 4:59 AM
F19060350: D17141.id.diff
Nov 29 2025, 9:13 AM
F19055774: D17141.diff
Nov 28 2025, 6:24 PM
F18838579: D17141.id41223.diff
Oct 27 2025, 11:35 AM
F18838096: D17141.id.diff
Oct 27 2025, 9:15 AM
F18835700: D17141.diff
Oct 26 2025, 6:08 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP96fbf37dcc11: Bring up contrast on light green / red diffs
Summary

Minor color saturation here, ideal for low quality monitors.

Test Plan

Review new colors in various scenarios.

pasted_file (880×2 px, 163 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Jan 4 2017, 10:37 PM
Herald added a subscriber: Korvin. · View Herald TranscriptJan 4 2017, 10:37 PM
epriestley accepted this revision.Jan 4 2017, 10:38 PM
epriestley edited edge metadata.

thx u

Harbormaster completed remote builds in B15106: Diff 41221.Jan 4 2017, 10:38 PM
chad planned changes to this revision.Jan 4 2017, 10:39 PM

actually going to spend some more time on this.

chad updated this revision to Diff 41223.Jan 4 2017, 11:06 PM
  • Stronger color hinting, but only on side of diffs
Harbormaster completed remote builds in B15108: Diff 41223.Jan 4 2017, 11:06 PM
chad edited the test plan for this revision. (Show Details)Jan 4 2017, 11:07 PM
Harbormaster completed remote builds in B15108: Diff 41223.Jan 4 2017, 11:07 PM
epriestley accepted this revision.Jan 4 2017, 11:07 PM
This revision is now accepted and ready to land.Jan 4 2017, 11:07 PM
Closed by commit rP96fbf37dcc11: Bring up contrast on light green / red diffs (authored by chad, committed by chad). · Explain WhyJan 4 2017, 11:18 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Jan 4 2017, 11:24 PM

let me know

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
applications/
differential/
render/
20 lines
4 lines
webroot/
rsrc/
css/
application/
differential/
10 lines

Diff 41226

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
Phabricator · Built by Phacility