Paths

Table of Contentst

Show an info view warning for ongoing or failed builds in Differential
ClosedPublic
Actions

Authored by epriestley on Jan 4 2017, 10:07 PM.

Tags

None

Referenced Files

	F13134417: D17140.diff
	Thu, May 2, 2:57 AM

	Unknown Object (File)
	Sun, Apr 28, 11:59 AM

	Unknown Object (File)
	Thu, Apr 25, 1:28 AM

	Unknown Object (File)
	Wed, Apr 24, 6:16 AM

	Unknown Object (File)
	Thu, Apr 11, 8:58 AM

	Unknown Object (File)
	Sun, Apr 7, 5:45 PM

	Unknown Object (File)
	Apr 1 2024, 12:58 AM

	Unknown Object (File)
	Mar 31 2024, 8:21 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10136: Show warning in Revision when build failed

Commits

rP2855470b312a: Show an info view warning for ongoing or failed builds in Differential

Summary

Fixes T10136. This reinforces ongoing or failed builds in the comment action area.

We already emit a similar message for unit test failures from arc unit. This should probably obsolete that, eventually.

Test Plan

Screen Shot 2017-01-04 at 2.04.51 PM.png (378×440 px, 25 KB)

Screen Shot 2017-01-04 at 2.04.26 PM.png (383×669 px, 28 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 4 2017, 10:07 PM

Harbormaster completed remote builds in B15105: Diff 41220.Jan 4 2017, 10:08 PM

chad accepted this revision.Jan 4 2017, 11:09 PM

This revision is now accepted and ready to land.Jan 4 2017, 11:09 PM

Closed by commit rP2855470b312a: Show an info view warning for ongoing or failed builds in Differential (authored by epriestley, committed by epriestley). · Explain WhyJan 4 2017, 11:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialUnitField.php

26 lines

Diff 41225

View Options

src/applications/differential/customfield/DifferentialUnitField.php

Show an info view warning for ongoing or failed builds in DifferentialClosedPublicActions