Page MenuHomePhabricator
Differential D17140

Show an info view warning for ongoing or failed builds in Differential
ClosedPublic
Actions

Authored by epriestley on Jan 4 2017, 10:07 PM.
Tags
None
Referenced Files
F14839099: D17140.diff
Fri, Jan 31, 8:31 PM
Unknown Object (File)
Fri, Jan 24, 6:38 PM
Unknown Object (File)
Fri, Jan 24, 6:38 PM
Unknown Object (File)
Fri, Jan 24, 6:38 PM
Unknown Object (File)
Fri, Jan 24, 6:38 PM
Unknown Object (File)
Thu, Jan 23, 5:27 AM
Unknown Object (File)
Fri, Jan 17, 7:58 PM
Unknown Object (File)
Sat, Jan 4, 10:03 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10136: Show warning in Revision when build failed
Commits
rP2855470b312a: Show an info view warning for ongoing or failed builds in Differential
Summary

Fixes T10136. This reinforces ongoing or failed builds in the comment action area.

We already emit a similar message for unit test failures from arc unit. This should probably obsolete that, eventually.

Test Plan

Screen Shot 2017-01-04 at 2.04.51 PM.png (378×440 px, 25 KB)

Screen Shot 2017-01-04 at 2.04.26 PM.png (383×669 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
customfield/
26 lines

Diff 41225

View Options

src/applications/differential/customfield/DifferentialUnitField.php

Loading...
Phabricator · Built by Phacility