Page MenuHomePhabricator

Preserve nonstandard ports during 404 redirects which add "/" to the ends of URIs
ClosedPublic

Authored by epriestley on Jan 3 2017, 5:54 PM.
Tags
None
Referenced Files
F14359840: D17134.diff
Fri, Dec 20, 9:44 AM
Unknown Object (File)
Tue, Dec 10, 3:53 AM
Unknown Object (File)
Sat, Dec 7, 11:51 PM
Unknown Object (File)
Fri, Dec 6, 5:51 AM
Unknown Object (File)
Sun, Nov 24, 10:58 PM
Unknown Object (File)
Wed, Nov 20, 8:17 PM
Unknown Object (File)
Nov 17 2024, 5:49 AM
Unknown Object (File)
Oct 21 2024, 4:38 AM
Subscribers
None

Details

Summary

Fixes T12058. When the user visits /maniphest, for example, we redirect to /maniphest/.

Since this redirect is very low-level (at the Aphront level, below the Site level) we need to preserve the request Host rather than correct it to PhabricatorEnv::getURI() or similar -- the request may be hiting a different Site like a blog domain.

Currently, we do not preserve the port. Instead, preserve the port if it is not a standard port for the protocol (80 for http, 443 for https).

Test Plan
  • Made a request with a missing slash and a normal port in my browser, got redirected normally.
  • Made a request with a missing slash and a nonstandard port, got redirected on the same port.
$ curl -H 'Host: local.phacility.com:123' -v http://local.phacility.com/diffusion
*   Trying 127.0.0.1...
* Connected to local.phacility.com (127.0.0.1) port 80 (#0)
> GET /diffusion HTTP/1.1
...
> 
< HTTP/1.1 302 Found
...
< Location: http://local.phacility.com:123/diffusion/
...

Diff Detail

Repository
rP Phabricator
Branch
redirect1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15088
Build 19804: Run Core Tests
Build 19803: arc lint + arc unit