Page MenuHomePhabricator
Differential D17107

Restore "Reclaim" and "Abandon" actions to Differential on EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 28 2016, 8:53 PM.
Tags
None
Referenced Files
F13060522: D17107.diff
Fri, Apr 19, 5:58 PM
Unknown Object (File)
Mon, Apr 1, 2:37 AM
Unknown Object (File)
Sat, Mar 30, 5:27 PM
Unknown Object (File)
Sat, Mar 30, 3:42 AM
Unknown Object (File)
Fri, Mar 29, 1:57 PM
Unknown Object (File)
Tue, Mar 26, 2:36 PM
Unknown Object (File)
Tue, Mar 26, 2:36 PM
Unknown Object (File)
Tue, Mar 26, 2:36 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rP3c5a17ba8a55: Restore "Reclaim" and "Abandon" actions to Differential on EditEngine
Summary

Ref T11114. This begins restoring comment actions to Differential, but on top of EditEngine.

Test Plan

Screen Shot 2016-12-28 at 12.49.26 PM.png (418×1 px, 44 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 28 2016, 8:53 PM
Herald edited edge metadata. · View Herald TranscriptDec 28 2016, 8:53 PM
epriestley updated this revision to Diff 41146.Dec 28 2016, 9:10 PM
  • Prevent these actions from generating transactions during web form submission.
chad accepted this revision.Dec 29 2016, 5:47 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 5:47 PM
Closed by commit rP3c5a17ba8a55: Restore "Reclaim" and "Abandon" actions to Differential on EditEngine (authored by epriestley, committed by epriestley). · Explain WhyDec 31 2016, 6:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
src/
10 lines
applications/
differential/
editor/
8 lines
storage/
5 lines
xaction/
67 lines
88 lines
62 lines
transactions/
commentaction/
28 lines
editfield/
40 lines
webroot/
rsrc/
css/
phui/
5 lines
js/
phuix/
22 lines

Diff 41166

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Loading...
View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionAbandonTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionActionTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php

Loading...
View Options

src/applications/transactions/commentaction/PhabricatorEditEngineStaticCommentAction.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorApplyEditField.php

Loading...
View Options

webroot/rsrc/css/phui/phui-form-view.css

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXFormControl.js

Loading...
Phabricator · Built by Phacility