Update PhabricatorPhabricatorAuthProvider client create URL
AbandonedPublic
Actions

Authored by dereckson on Dec 25 2016, 11:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 20, 8:30 AM

	Unknown Object (File)
	Fri, Nov 15, 7:58 PM

	Unknown Object (File)
	Fri, Nov 15, 12:44 AM

	Unknown Object (File)
	Tue, Nov 12, 4:04 AM

	Unknown Object (File)
	Thu, Nov 7, 11:45 PM

	Unknown Object (File)
	Mon, Oct 28, 7:51 PM

	Unknown Object (File)
	Mon, Oct 28, 9:30 AM

	Unknown Object (File)
	Oct 15 2024, 6:46 PM

View All Files

Subscribers

epriestley

Details

Reviewers

None

Group Reviewers

Blessed Reviewers

Summary

Phabricator form URLs have been updated
from /create to /edit/form/<form id>.

PhabricatorPhabricatorAuthProvider still used legacy URL,
sending the Phabricator administrator to a 404 page.

Test Plan

Auth, create a new Phabricator provider, check URL

Diff Detail

Repository

rP Phabricator

Branch

oauth-config (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15028
Build 19714: arc lint + arc unit

Event Timeline

dereckson created this revision.Dec 25 2016, 11:28 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 25 2016, 11:28 PM

Herald added a subscriber: epriestley. · View Herald Transcript

This should use EditEngine to generate the URI instead, but there is currently no easy way to do that.

A better long-term solution than a temporary fix is wanted, per D17104#203911

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

provider/

PhabricatorPhabricatorAuthProvider.php

2 lines

Diff 41141

View Options

src/applications/auth/provider/PhabricatorPhabricatorAuthProvider.php

Update PhabricatorPhabricatorAuthProvider client create URLAbandonedPublicActions