Page MenuHomePhabricator

Redirect `/source/x` (no slash) to `/source/x/` (canonical) when viewer is logged out and "x" is public
ClosedPublic

Authored by epriestley on Dec 20 2016, 1:42 PM.
Tags
None
Referenced Files
F13168425: D17097.diff
Tue, May 7, 7:42 AM
Unknown Object (File)
Sun, May 5, 10:51 AM
Unknown Object (File)
Fri, May 3, 7:20 AM
Unknown Object (File)
Thu, Apr 25, 1:29 AM
Unknown Object (File)
Thu, Apr 11, 8:58 AM
Unknown Object (File)
Thu, Apr 11, 12:31 AM
Unknown Object (File)
Apr 4 2024, 3:57 AM
Unknown Object (File)
Apr 4 2024, 2:57 AM
Subscribers
None

Details

Summary

Fixes T12035. Normally, the "abc" -> "abc/" redirect is handled automatically when "abc" hits a 404.

However, in this case, "source/x" does not 404. We route this to a valid controller because some VCS requests omit the slashes, then manually perform the redirect if we aren't serving a VCS request.

Allow this controller to serve public resources so we can serve the redirect to logged-out users instead of prompting them to login so they can be redirected.

Test Plan

Visited /source/x as a logged-out user, where x is a public repository.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable